Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements for long file and commit names #30374

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Various improvements for long file and commit names #30374

merged 6 commits into from
Apr 10, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 9, 2024 •
edited
Loading

Fixes: #29438

This contains numerous enhancements for how large commit messages and large filenames render. Another notable change is that the file path is no longer cut off by backend at 30 chars, but rendered in full with wrapping.

Screenshot 2024-04-09 at 21 53 57
Screenshot 2024-04-09 at 21 44 24
Screenshot 2024-04-09 at 21 19 03
Screenshot 2024-04-09 at 21 18 52

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 9, 2024
@silverwind silverwind added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 and removed modifies/templates This PR modifies the template files labels Apr 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 9, 2024
@silverwind
Copy link
Member Author

silverwind commented Apr 9, 2024 •
edited
Loading

Another nice improvement for the commits table in 9f47323. Now the timestamp column takes up much less width, makeing more room for the commit message.

Interestingly, there was already a #repo-files-table td.age {width: 120px} rule but it was ineffective because of table-layout: fixed. The new width calculation of that th is definitely advanced, but works in all viewport widths well in my testing.

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2024
@silverwind silverwind enabled auto-merge (squash) April 10, 2024 05:50
@silverwind silverwind merged commit 50099d7 into go-gitea:main Apr 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 10, 2024
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Apr 10, 2024
@silverwind @GiteaBot
Various improvements for long file and commit names (go-gitea#30374)
eb62060 
Fixes: go-gitea#29438

This contains numerous enhancements for how large commit messages and
large filenames render. Another notable change is that the file path is
no longer cut off by backend at 30 chars, but rendered in full with
wrapping.

<img width="1329" alt="Screenshot 2024-04-09 at 21 53 57"
src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182">
<hr>
<img width="711" alt="Screenshot 2024-04-09 at 21 44 24"
src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57">
<hr>
<img width="439" alt="Screenshot 2024-04-09 at 21 19 03"
src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61">
<hr>
<img width="444" alt="Screenshot 2024-04-09 at 21 18 52"
src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964">

---------

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Apr 10, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 10, 2024
silverwind added a commit that referenced this pull request Apr 10, 2024
@GiteaBot @silverwind
Various improvements for long file and commit names (#30374) (#30386)
6c5b088 
Backport #30374 by @silverwind

Fixes: #29438

This contains numerous enhancements for how large commit messages and
large filenames render. Another notable change is that the file path is
no longer cut off by backend at 30 chars, but rendered in full with
wrapping.

<img width="1329" alt="Screenshot 2024-04-09 at 21 53 57"
src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182">
<hr>
<img width="711" alt="Screenshot 2024-04-09 at 21 44 24"
src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57">
<hr>
<img width="439" alt="Screenshot 2024-04-09 at 21 19 03"
src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61">
<hr>
<img width="444" alt="Screenshot 2024-04-09 at 21 18 52"
src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964">

Co-authored-by: silverwind <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5b272f1 
* giteaofficial/main:
  Upgrade golangci-lint to v1.57.2 (go-gitea#30401)
  Replace MSSQL driver with a better maintained version (go-gitea#30390)
  [skip ci] Updated translations via Crowdin
  Minor color tweaks (go-gitea#30397)
  Use raw Wiki links for non-renderable Wiki files (go-gitea#30273)
  Various improvements for long file and commit names (go-gitea#30374)
@silverwind silverwind mentioned this pull request Apr 16, 2024
Merged
silverwind added a commit that referenced this pull request Apr 17, 2024
@silverwind @GiteaBot
Fix and tweak pull request commit list (#30528)
311f526 
Fixes #30493, regression from
#30374.

Also did the flexbox convertion as suggested by the existing comment.

<img width="850" alt="Screenshot 2024-04-16 at 22 28 48"
src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e">

Co-authored-by: Giteabot <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Apr 22, 2024
@silverwind @algernon
Fix and tweak pull request commit list (#30528)
eea7ea9 
Fixes go-gitea/gitea#30493, regression from
go-gitea/gitea#30374.

Also did the flexbox convertion as suggested by the existing comment.

<img width="850" alt="Screenshot 2024-04-16 at 22 28 48"
src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e">

Co-authored-by: Giteabot <[email protected]>
(cherry picked from commit 311f5261cdb23b46d3f510e40fd4e2ac06e376c0)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 16, 2024
@silverwind @earl-warren
Fix and tweak pull request commit list (#30528)
6917b25 
Fixes go-gitea/gitea#30493, regression from
go-gitea/gitea#30374.

Also did the flexbox convertion as suggested by the existing comment.

<img width="850" alt="Screenshot 2024-04-16 at 22 28 48"
src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e">

Co-authored-by: Giteabot <[email protected]>
(cherry picked from commit 311f5261cdb23b46d3f510e40fd4e2ac06e376c0)
(cherry picked from commit eea7ea9)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Wrong UI for lastest commit info when commit message is too long
5 participants
@silverwind @lunny @delvh @wxiaoguang @GiteaBot