Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce checkbox size to 15px #30346

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Reduce checkbox size to 15px #30346

merged 2 commits into from
Apr 9, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 8, 2024 •
edited

16 seems to big, 14 too small. Let's do 15. Alignment:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2024
@lunny
Copy link
Member

lunny commented Apr 9, 2024

And maybe the border should be smaller?

@lunny lunny enabled auto-merge (squash) April 9, 2024 03:04
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 9, 2024
@lunny lunny merged commit 72dc75e into go-gitea:main Apr 9, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 9, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 9, 2024
@silverwind @GiteaBot
Reduce checkbox size to 15px (go-gitea#30346)
84b15a6 
16 seems to big, 14 too small. Let's do 15. Alignment:

<img width="181" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/f2988611-dee2-492e-a18f-dc5ab3a1cd6c">
@GiteaBot GiteaBot mentioned this pull request Apr 9, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 9, 2024
silverwind added a commit that referenced this pull request Apr 9, 2024
@GiteaBot @silverwind
Reduce checkbox size to 15px (#30346) (#30347)
4c8c10b 
Backport #30346 by @silverwind

16 seems to big, 14 too small. Let's do 15. Alignment:

<img width="181" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/f2988611-dee2-492e-a18f-dc5ab3a1cd6c">

Co-authored-by: silverwind <[email protected]>
@silverwind silverwind deleted the checkbox15 branch April 9, 2024 06:06
@silverwind
Copy link
Member Author

And maybe the border should be smaller?

We don't control that currently, that's a browser style.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 10, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e1057cc 
* giteaofficial/main:
  Fix line height on inline code preview (go-gitea#30372)
  Refactor more filterslice (go-gitea#30370)
  Fix ambiguous id when fetch Actions tasks (go-gitea#30382)
  Fix floated list items (go-gitea#30377)
  Fix actions design about default actions download url (go-gitea#30360)
  Add container.FilterSlice function (go-gitea#30339)
  Fix label-list rendering in timeline, decrease gap (go-gitea#30342)
  Performance optimization for git push (go-gitea#30104)
  Reduce checkbox size to 15px (go-gitea#30346)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @lunny @lafriks @a1012112796 @wxiaoguang @GiteaBot