Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create commit status (#30225) #30340

Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 8, 2024

Partially backport #30223

This PR uses the service layer CreateCommitstatus method instead of the git model method.

Partially backport go-gitea#30223

This PR uses the service layer `CreateCommitstatus` method instead of
the git model method.
@lunny lunny added the type/bug label Apr 8, 2024
@lunny lunny added this to the 1.21.11 milestone Apr 8, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 8, 2024
@lunny lunny mentioned this pull request Apr 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2024
@lafriks lafriks enabled auto-merge (squash) April 8, 2024 23:09
@lafriks lafriks merged commit 3f6ddd9 into go-gitea:release/v1.21 Apr 8, 2024
27 checks passed
@lunny lunny deleted the lunny/fix_create_commit_status2 branch April 9, 2024 01:39
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants