Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused field in form #3023

Merged
merged 3 commits into from
Nov 29, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Remove unused OldTitle field from NewWikiForm. The wiki's old title is inferred from the :page parameter in the URL.

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #3023 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3023      +/-   ##
==========================================
- Coverage   33.03%   32.98%   -0.05%     
==========================================
  Files         270      270              
  Lines       39534    39534              
==========================================
- Hits        13061    13042      -19     
- Misses      24617    24637      +20     
+ Partials     1856     1855       -1
Impacted Files Coverage Δ
modules/auth/repo_form.go 32.87% <ø> (ø) ⬆️
models/repo_indexer.go 45.54% <0%> (-6.44%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033ad9a...85b54fe. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 29, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 29, 2017
@lunny
Copy link
Member

lunny commented Nov 29, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2017
@lafriks lafriks merged commit 013db70 into go-gitea:master Nov 29, 2017
@ethantkoenig ethantkoenig deleted the wiki/remove_unused branch November 29, 2017 21:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants