Open to Pull Request form directly on compare page

[silverwind]

When creating a PR on Gitea, there is this useless step where one has to click a button on the compare page. Removed it. Note, I'm not yet sure what the relation to .Flash here is.

Instead, remove this button and show the form directly. This matches GitHub's behaviour as well.

[delvh]

Finally.
I was waiting for this PR for too long

[silverwind]

I'm willing to backport this nice enhancement to 1.22.

[lunny]

It depends on whether the repository is archived/mirror and whether the compared are two branches.

[wxiaoguang]

Many show-form classes for <a class="show-form"> should be also removed IMO. They were no-op from beginning.

[silverwind]

It depends on whether the repository is archived/mirror and whether the compared are two branches.

The if condition on the form have not changed. I just moved one condition that was on the button to th form. Behaviour for showing the form is the same as was previously for the button.

[silverwind]

Many show-form classes for <a class="show-form"> should be also removed IMO. They were no-op from beginning.

Removed them and did some minor styling tweaks on that box:

[silverwind]

Ready again.

[lunny]

But sometimes, you just want to do a compare but not create a pull request?

[silverwind]

But sometimes, you just want to do a compare but not create a pull request?

You always have the diff to compare at bottom. I see GitHub UI features the button on compare page as well, but I think under some circumstances the button is hidden and it opens directly to the form:

main...release/v1.22

I think we don't need such complications, we can make the form sufficiently compact and then the page will work for both purposes.

[lunny]

But sometimes, you just want to do a compare but not create a pull request?

You always have the diff to compare at bottom. I see GitHub UI features the button on compare page as well, but I think under some circumstances the button is hidden and it opens directly to the form:

main...release/v1.22

I think we don't need such complications, we can make the form sufficiently compact and then the page will work for both purposes.

But that will bothering. The previous design, there is only 1 line as a hint, but know whatever you want to create or not create a pull request, you will always see the creating pull request form.

[silverwind]

Maybe we just need a way to skip the button in certain situations. On GitHub, I can open /user/repo/pull/new/branch (from SSH message) and if there is no PR yet, it will open directly to the form. On gitea, I think it links to the compare page and always requires clicking the button.

Another potential difference with GitHub is that when the diff and/or commit count is small it only shows the diff, not the commit list.

[silverwind]

Checked how github does it:

https://github.com/silverwind/gitea/pull/new/rn

Redirects to

https://github.com/go-gitea/gitea/compare/main...silverwind:gitea:rn?expand=1

So we just need to implement the expand option and use it in places where it makes sense to open directly to the form.