Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery .attr from the diff page #30021

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Remove jQuery .attr from the diff page #30021

merged 4 commits into from
Mar 23, 2024

Commits on Mar 23, 2024

  1. Remove jQuery .attr from the diff page 

    - Switched from jQuery `.attr` to plain javascript `getAttribute` and `setAttribute`
- Tested the review box counter and Previous/Next code review conversation buttons. They work as before

Signed-off-by: Yarden Shoham <[email protected]>
    @yardenshoham
    yardenshoham committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    9b12e97 View commit details
    Browse the repository at this point in the history

  2. Update web_src/js/features/repo-diff.js 

    Co-authored-by: silverwind <[email protected]>
    @yardenshoham @silverwind
    yardenshoham and silverwind committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    7b5aa9e View commit details
    Browse the repository at this point in the history

  3. Update web_src/js/features/repo-diff.js

    @yardenshoham
    yardenshoham committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    34a3762 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into repo-diff-jquery-attr

    @yardenshoham
    yardenshoham committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    5e11780 View commit details
    Browse the repository at this point in the history