Upgrade xorm to v1.3.9 and improve some migrations Sync #29899
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/go
| if _, err := x.SyncWithOptions(xorm.SyncOptions{ | ||
| IgnoreIndices: true, | ||
| IgnoreConstrains: true, | ||
| }, new(HookTask)); err != nil { | ||
| return err | ||
| } | ||
| _, err := x.Exec("UPDATE hook_task SET payload_version = 1 WHERE payload_version IS NULL") |
There was a problem hiding this comment.
I think we need to switch these statements around.
Otherwise, it seems inconsistent.
Why is it even necessary, even though it wasn't previously?
There was a problem hiding this comment.
This maybe an unrelated change to this PR. I just found v290 missed the update operations. Because creating a new column with default value will not update the old record automatically. It should be a bug of previous PR.
There was a problem hiding this comment.
Maybe split this change out into separate PR?
GiteaBot
added
lgtm/need 1
|
How to decide when to ignore indices and constrains? |
It depends on the context of the migration. If the migration just want to create a new index, then it can ignore deleting index. |
No description provided.