Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Temporal.PlainDate for absolute dates (#29804) #29808

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Use Temporal.PlainDate for absolute dates (#29804) #29808

merged 2 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. Use Temporal.PlainDate for absolute dates (go-gitea#29804) 

    Use the upcoming
[Temporal.PlainDate](https://tc39.es/proposal-temporal/docs/plaindate.html)
via polyfill. If there is any remaining bugs in `<absolute-date>` this
will iron them out. I opted for the lightweight polyfill because both
seem to achieve our goal of localizeable absolute dates.

- With
[`@js-temporal/polyfill`](https://www.npmjs.com/package/@js-temporal/polyfill)
chunk size goes from 81.4 KiB to 274 KiB
- With
[`temporal-polyfill`](https://www.npmjs.com/package/temporal-polyfill)
chunk size goes from 81.4 KiB to 142 KiB

Also see [this
table](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#comparison-with-js-temporalpolyfill)
for more comparisons of these polyfills. Soon there will be
[treeshakable
API](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#tree-shakable-api)
as well which will further reduce size.
    @silverwind
    silverwind committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f1ec847 View commit details
    Browse the repository at this point in the history

  2. add package

    @silverwind
    silverwind committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f5f7a04 View commit details
    Browse the repository at this point in the history