Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make runs-on support variable expression (#29468) #29782

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Make runs-on support variable expression (#29468) #29782

merged 1 commit into from
Mar 14, 2024

Conversation

sillyguodong
Copy link
Contributor

backport #29468

Close issue: https://gitea.com/gitea/act_runner/issues/445
Follow: https://gitea.com/gitea/act/pulls/91

Move getSecretsOfTask and getVariablesOfTask under models because of circular dependency issues.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2024
@GiteaBot GiteaBot added this to the 1.21.9 milestone Mar 14, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/dependencies labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@lunny lunny merged commit 538efb9 into go-gitea:release/v1.21 Mar 14, 2024
27 checks passed
@sillyguodong sillyguodong deleted the backport/support_vars_in_runs_on branch March 14, 2024 06:04
@wolfogre wolfogre mentioned this pull request Apr 11, 2024
Merged
wolfogre added a commit that referenced this pull request Apr 11, 2024
@wolfogre
No global variables (#30402)
6cfe67c 
Fix #30361, regression of #29782 which is a backport, not the original
#29468.

#29468 did a small refactor which introduced a new function
`GetVariablesOfRun`. However, it's designed for v1.22 which supports
global variables.

After backporting it to v1.21, it will still try to get global
variables, which causes it to retrieve all variables.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/dependencies modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sillyguodong @lunny @a1012112796 @GiteaBot