Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong test usage of AppSubURL (#29459) #29488

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #29459 by @KN4CK3R

The tests use an invalid setting.AppSubURL. The wrong behaviour disturbs other PRs like #29222 and #29427.

The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like go-gitea#29222 and go-gitea#29427.
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels Feb 29, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Feb 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2024
@lunny lunny merged commit c293e34 into go-gitea:release/v1.21 Feb 29, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants