Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated GOGS_WORK_DIR use #2946

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Drop deprecated GOGS_WORK_DIR use #2946

merged 2 commits into from
Nov 21, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Nov 20, 2017

I think it's about time to drop GOGS_WORK_DIR

@codecov-io
Copy link

codecov-io commented Nov 20, 2017 •
edited
Loading

Codecov Report

Merging #2946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2946   +/-   ##
=======================================
  Coverage   27.24%   27.24%           
=======================================
  Files          89       89           
  Lines       17640    17640           
=======================================
  Hits         4806     4806           
  Misses      12146    12146           
  Partials      688      688

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd09d1f...b3507f3. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2017
@lafriks lafriks added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Nov 20, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 20, 2017
@lafriks
Copy link
Member

lafriks commented Nov 20, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2017
@lunny
Copy link
Member

lunny commented Nov 21, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2017
@lunny lunny merged commit 1f7aab6 into go-gitea:master Nov 21, 2017
@cez81 cez81 deleted the drop_gogs_work_dir branch November 21, 2017 12:17
@strk
Copy link
Member

strk commented Nov 24, 2017 via email

@lafriks
Copy link
Member

lafriks commented Nov 24, 2017

@strk do you use it?

@strk
Copy link
Member

strk commented Nov 24, 2017 via email

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/deployment
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cez81 @codecov-io @lafriks @lunny @strk @tboerger