Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change primary email before account activation #29412

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Allow to change primary email before account activation #29412

merged 3 commits into from
Feb 27, 2024

Conversation

wxiaoguang
Copy link
Contributor

image

image

@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 26, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Feb 26, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2024
@wolfogre
Copy link
Member

Maybe I haven't read the code carefully, but is there a CAPTCHA validation (if it's enabled) to change email before account activation? I mean I can:

  • Register with an email address, pass the CAPTCHA validation on the registration page manually.
  • Use a bot script to resend validation emails automatically, and each time with a different email address.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Feb 27, 2024 •
edited

Maybe I haven't read the code carefully, but is there a CAPTCHA validation (if it's enabled) to change email before account activation? I mean I can:

* Register with an email address, pass the CAPTCHA validation on the registration page manually.

* Use a bot script to resend validation emails automatically, and each time with a different email address.

There is no difference. Because the "limit" is done by username:

image

And IIRC it doesn't ask for CAPTCHA when adding new emails (on the user's setting page) .....

@lunny
Copy link
Member

lunny commented Feb 27, 2024

Maybe I haven't read the code carefully, but is there a CAPTCHA validation (if it's enabled) to change email before account activation? I mean I can:

* Register with an email address, pass the CAPTCHA validation on the registration page manually.

* Use a bot script to resend validation emails automatically, and each time with a different email address.

There is no difference. Because the "limit" is done by username:

image

As I have tested, it's unavailable since it's unrelated to this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 27, 2024 10:30
@a1012112796
Copy link
Member

why not allow not actived user using '/user/settings' router directly?

@lunny
Copy link
Member

lunny commented Feb 27, 2024

why not allow not actived user using '/user/settings' router directly?

Inactive users should have the minimum services.

@wxiaoguang wxiaoguang merged commit 6bdfc84 into go-gitea:main Feb 27, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the feat-change-reg-email branch February 27, 2024 13:10
@wxiaoguang wxiaoguang mentioned this pull request Feb 27, 2024
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 29, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
dd1ca6c 
* giteaofficial/main: (23 commits)
  Fix wrong test usage of `AppSubURL` (go-gitea#29459)
  Improve contrast on blame timestamp, fix double border (go-gitea#29482)
  Fix/Improve `processWindowErrorEvent` (go-gitea#29407)
  Apply compact padding to small buttons with svg icons (go-gitea#29471)
  Fix counter display number incorrectly displayed on the page (go-gitea#29448)
  Fix incorrect user location link on profile page (go-gitea#29474)
  Fix workflow trigger event bugs (go-gitea#29467)
  Fix URL calculation in clone input box (go-gitea#29470)
  Remove jQuery from the "find file" page (go-gitea#29456)
  Move generate from module to service (go-gitea#29465)
  The job should always run when `if` is `always()` (go-gitea#29464)
  Recolor dark theme to blue shade (go-gitea#29283)
  Let ctx.FormOptionalBool() return optional.Option[bool] (go-gitea#29461)
  Implement actions badge svgs (go-gitea#28102)
  Fix missed return (go-gitea#29450)
  Use tailwind instead of `gt-[wh]-` helper classes (go-gitea#29423)
  Lock issues and pulls faster (go-gitea#29436)
  Allow to change primary email before account activation (go-gitea#29412)
  Update docs about `DEFAULT_ACTIONS_URL` (go-gitea#29442)
  Only use supported sort order for "explore/users" page (go-gitea#29430)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wxiaoguang @wolfogre @lunny @a1012112796 @silverwind @GiteaBot