Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validity of the FROM email address not being checked #29347

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

carlosfelgueiras
Copy link
Contributor

Fixes #27188.
Introduces a check on the installation that tries to parse the FROM address. If it fails, shows a new error message to the user.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2024
routers/install/install.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2024
@6543 6543 added the type/bug label Feb 23, 2024
@6543 6543 enabled auto-merge (squash) February 23, 2024 22:48
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2024
@6543 6543 merged commit 6f6120d into go-gitea:main Feb 23, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 23, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2024
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 24, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 24, 2024
)

Fixes go-gitea#27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

---------

Co-authored-by: KN4CK3R <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 24, 2024
lunny pushed a commit that referenced this pull request Feb 24, 2024
…9360)

Backport #29347 by @carlosfelgueiras

Fixes #27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

Co-authored-by: Carlos Felgueiras <[email protected]>
Co-authored-by: KN4CK3R <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid mailer.FROM causes the installation to fail.
6 participants