Implement some action notifier functions #29173

yp05327 · 2024-02-15T05:47:13Z

Add support for the following activity types of pull_request

assigned
unassigned
review_requested
review_request_removed
milestoned
demilestoned

yp05327 · 2024-02-15T08:23:23Z

UI should also be fix as we only have scheduled and commit here. But that can be another PR, as this fix will be a little big change.

services/actions/notifier.go

KN4CK3R · 2024-02-15T11:18:07Z

services/actions/notifier.go

+ return
+ }
+
+ permission, _ := access_model.GetUserRepoPermission(ctx, issue.Repo, issue.Poster)


Could move this below if issue.IsPull because it's only needed for issues. (Why is that the case? Why has the pull request AccessModeNone but the issue has the real permissions?)

Why has the pull request AccessModeNone but the issue has the real permissions?

I have no idea about this now. I think we can ask @wolfogre, as it comes from the origin implement.

Whether all the concerns are resolved? @KN4CK3R @yp05327

The permission is used to fill the payload to allow scripts in actions to check if they can push or pull the repo. It inherits the design of webhook payloads, I don't think the actions scripts really read it, so it should be OK to use the same permission for both issues and PRs. It doesn't affect the actual permissions of actions scripts.

silverwind · 2024-02-15T20:14:39Z

UI should also be fix as we only have scheduled and commit here. But that can be another PR, as this fix will be a little big change.

What's the problem? The spacing around :?

yp05327 · 2024-02-16T00:22:31Z

UI should also be fix as we only have scheduled and commit here. But that can be another PR, as this fix will be a little big change.

What's the problem? The spacing around :?

If runs are triggered by some special hooks, like assigned or unassigned, it will always be Commit xxxxxx, which can be PR#xxxx Assigned/Unassigned. Or you will see some thing like this, users cannot know which operation triggered these runs. They look all the same, but actually from different hooks.

GiteaBot · 2024-02-18T10:58:50Z

I was unable to create a backport for 1.21. @yp05327, please send one manually. 🍵

go run ./contrib/backport 29173
...  // fix git conflicts if any
go run ./contrib/backport --continue

* giteaofficial/main: (28 commits) Improve TrHTML and add more tests (go-gitea#29228) Convert visibility to number (go-gitea#29226) Implement some action notifier functions (go-gitea#29173) Artifact deletion in actions ui (go-gitea#27172) Update docs for actions variables (go-gitea#29239) Refactor more code in templates (go-gitea#29236) Use "Safe" modifier for manually constructed safe HTML strings in templates (go-gitea#29227) Remove jQuery from the repo release form (go-gitea#29225) Make submit event code work with both jQuery event and native event (go-gitea#29223) Remove jQuery from repo migrate page (go-gitea#29219) Remove unneccesary `initUserAuthLinkAccountView` from "link account" page (go-gitea#29217) Fix labels referencing the wrong ID in the user profile settings (go-gitea#29199) Fix label `for` pointing to a `name` instead of `id` in webhook settings (go-gitea#29209) Load outdated comments when (un)resolving conversation on PR timeline (go-gitea#29203) Fix missing template for follow button in organization (go-gitea#29215) Enable markdownlint `no-trailing-punctuation` and `no-blanks-blockquote` (go-gitea#29214) Remove jQuery from the webhook editor (go-gitea#29211) Remove jQuery from issue reference context popup attach (go-gitea#29216) fix typo (go-gitea#29212) Fix debian InRelease Acquire-By-Hash newline (go-gitea#29204) ...

Backport go-gitea#29173 Fix go-gitea#29166 Add support for the following activity types of `pull_request` - assigned - unassigned - review_requested - review_request_removed - milestoned - demilestoned

yp05327 · 2024-02-19T00:03:24Z

emmm, it seems that it is same to 29190

https://github.com/yp05327/gitea/tree/backport-29173-v1.21

Fix go-gitea#29166 Add support for the following activity types of `pull_request` - assigned - unassigned - review_requested - review_request_removed - milestoned - demilestoned

Backport #29173 Fix #29166 Add support for the following activity types of `pull_request` - assigned - unassigned - review_requested - review_request_removed - milestoned - demilestoned

Fix go-gitea#29166 Add support for the following activity types of `pull_request` - assigned - unassigned - review_requested - review_request_removed - milestoned - demilestoned (cherry picked from commit 1a6e1cb)

github-actions · 2024-03-01T00:04:56Z

Automatically locked because of our CONTRIBUTING guidelines

yp05327 added 2 commits February 15, 2024 05:06

add IssueChangeAssignee

1037f8f

add PullRequestReviewRequest

79f0859

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2024

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2024

yp05327 added 2 commits February 15, 2024 08:11

add IssueChangeMilestone

6cb2831

add unsupported activity types

a69df17

pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2024

yp05327 marked this pull request as ready for review February 15, 2024 08:24

yp05327 changed the title ~~[WIP] Implement some action notifier functions~~ Implement some action notifier functions Feb 15, 2024

KN4CK3R reviewed Feb 15, 2024

View reviewed changes

merge similar codes

85e0799

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2024

lunny added the topic/gitea-actions related to the actions of Gitea label Feb 17, 2024

lunny requested review from wolfogre and Zettat123 February 17, 2024 07:31

wolfogre approved these changes Feb 18, 2024

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2024

lunny approved these changes Feb 18, 2024

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2024

lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 18, 2024

Merge branch 'main' into implement-action-notifier-funcs

f9a2c19

lunny added this to the 1.22.0 milestone Feb 18, 2024

lunny enabled auto-merge (squash) February 18, 2024 06:00

lunny disabled auto-merge February 18, 2024 06:01

GiteaBot added 2 commits February 18, 2024 17:52

Merge branch 'main' into implement-action-notifier-funcs

4206437

Merge branch 'main' into implement-action-notifier-funcs

54c70ba

KN4CK3R approved these changes Feb 18, 2024

View reviewed changes

lunny enabled auto-merge (squash) February 18, 2024 10:09

Merge branch 'main' into implement-action-notifier-funcs

3295176

lunny merged commit 1a6e1cb into go-gitea:main Feb 18, 2024
26 checks passed

GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 18, 2024

yp05327 mentioned this pull request Feb 20, 2024

No conflicts but can not send backports GiteaBot/gitea-backporter#119

Closed

yp05327 mentioned this pull request Feb 22, 2024

Implement some action notifier functions (#29173) #29308

Merged

lunny added the backport/done All backports for this PR have been created label Feb 22, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024

yp05327 deleted the implement-action-notifier-funcs branch March 19, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement some action notifier functions #29173

Implement some action notifier functions #29173

yp05327 commented Feb 15, 2024 •

edited

Loading

yp05327 commented Feb 15, 2024 •

edited

Loading

KN4CK3R Feb 15, 2024

yp05327 Feb 16, 2024

lunny Feb 18, 2024

wolfogre Feb 18, 2024 •

edited

Loading

silverwind commented Feb 15, 2024

yp05327 commented Feb 16, 2024 •

edited

Loading

GiteaBot commented Feb 18, 2024

yp05327 commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024

Implement some action notifier functions #29173

Implement some action notifier functions #29173

Conversation

yp05327 commented Feb 15, 2024 • edited Loading

yp05327 commented Feb 15, 2024 • edited Loading

KN4CK3R Feb 15, 2024

Choose a reason for hiding this comment

yp05327 Feb 16, 2024

Choose a reason for hiding this comment

lunny Feb 18, 2024

Choose a reason for hiding this comment

wolfogre Feb 18, 2024 • edited Loading

Choose a reason for hiding this comment

silverwind commented Feb 15, 2024

yp05327 commented Feb 16, 2024 • edited Loading

GiteaBot commented Feb 18, 2024

yp05327 commented Feb 19, 2024 • edited Loading

github-actions bot commented Mar 1, 2024

yp05327 commented Feb 15, 2024 •

edited

Loading

yp05327 commented Feb 15, 2024 •

edited

Loading

wolfogre Feb 18, 2024 •

edited

Loading

yp05327 commented Feb 16, 2024 •

edited

Loading

yp05327 commented Feb 19, 2024 •

edited

Loading