Disallow merge when required checked are missing #29143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
MarkusAmshove
changed the title
wxiaoguang
reviewed
Feb 16, 2024
wxiaoguang
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/need 1
Co-authored-by: wxiaoguang <[email protected]>
delvh
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
lunny
reviewed
Feb 17, 2024
wxiaoguang
reviewed
Feb 17, 2024
GiteaBot
added
lgtm/blocked
GiteaBot
added
lgtm/done
Zettat123
approved these changes
Feb 19, 2024
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @MarkusAmshove, please send one manually. 🍵 |
GiteaBot
added
backport/manual
MarkusAmshove
added a commit
to MarkusAmshove/gitea
that referenced
this pull request
Feb 19, 2024
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Feb 19, 2024
backport #29143 Co-authored-by: wxiaoguang <[email protected]>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]> (cherry picked from commit a11ccc9)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21892
This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met.
Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported.
Any feedback is welcome, first time Go :-)
I'm also not sure if the changes in the template break something else
Given the following branch protection:
This was shown before the change:
With the change, it is now shown as this: