Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display friendly error message #29105

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Display friendly error message #29105

merged 2 commits into from
Feb 8, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 8, 2024

ctx.Error only displays the text but ctx.ServerError renders the usual error page.

@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 8, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2024
@KN4CK3R KN4CK3R added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@jolheiser jolheiser enabled auto-merge (squash) February 8, 2024 21:36
@jolheiser jolheiser merged commit da2f037 into go-gitea:main Feb 8, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Feb 8, 2024

I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 29105
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 8, 2024
@KN4CK3R KN4CK3R deleted the fix-wrong-error-method branch February 9, 2024 10:27
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@KN4CK3R @silverwind
Display friendly error message (go-gitea#29105)
5ca2daf 
`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 24, 2024
@KN4CK3R @lunny
Display friendly error message (go-gitea#29105)
865f8bb 
`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.
@lunny lunny mentioned this pull request Feb 24, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 24, 2024
lunny added a commit that referenced this pull request Feb 24, 2024
@lunny @KN4CK3R
Display friendly error message (#29105) (#29363)
a1c0b3a 
Backport #29105 

`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.

Co-authored-by: KN4CK3R <[email protected]>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@KN4CK3R @earl-warren
[gitea] Display friendly error message (go-gitea#29105)
045bd09 
`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.

(cherry picked from commit da2f037)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KN4CK3R @GiteaBot @silverwind @delvh @lunny @jolheiser