-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid showing unnecessary JS errors when there are elements with different origin on the page #29081
Conversation
43ab996
to
240567b
Compare
return false; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we detect the iframe document via el.ownerDocument !== document
and ignore those? I don't think we want to run the mutation callbacks on any iframe content (mermaid and user-configured renderers are the only cases I know of).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 6299b57 , and added more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is fine as-is, so above comment is an optional enhancement.
…erent origin on the page (go-gitea#29081) Try to fix go-gitea#29080
…erent origin on the page (#29081) (#29089) Backport #29081 by wxiaoguang Try to fix #29080 Co-authored-by: wxiaoguang <[email protected]>
…erent origin on the page (go-gitea#29081) Try to fix go-gitea#29080
…ith different origin on the page (go-gitea#29081) Try to fix go-gitea#29080 (cherry picked from commit f290c24)
Try to fix #29080