Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience for outdated comments #29050

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 4, 2024

Try to improve #28949

  1. Make ctx.Data["ShowOutdatedComments"] = true by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable.
  2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when ShowOutdatedComments = false)

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2024
@wxiaoguang wxiaoguang linked an issue Feb 4, 2024 that may be closed by this pull request
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 4, 2024
@lunny lunny added the topic/ux How users interact with Gitea label Feb 4, 2024
@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 4, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Feb 6, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 8, 2024 01:26
@wxiaoguang wxiaoguang merged commit a4859dc into go-gitea:main Feb 8, 2024
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 8, 2024
Try to improve go-gitea#28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 8, 2024
wxiaoguang added a commit that referenced this pull request Feb 8, 2024
Backport #29050 by wxiaoguang

Try to improve #28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang wxiaoguang deleted the improve-review-outdated branch February 14, 2024 05:33
lunny pushed a commit that referenced this pull request Feb 17, 2024
…#29203)

Relates to #28654, #29039 and #29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown.
So they should also be loaded when (un)resolving a conversation on the
timeline page.
jpraet added a commit to jpraet/gitea that referenced this pull request Feb 17, 2024
…go-gitea#29203)

Backport go-gitea#29203

Relates to go-gitea#28654, go-gitea#29039 and go-gitea#29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown.
So they should also be loaded when (un)resolving a conversation on the
timeline page.
lunny pushed a commit that referenced this pull request Feb 18, 2024
…#29203) (#29221)

Backport #29203

Relates to #28654, #29039 and #29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown. So they should
also be loaded when (un)resolving a conversation on the timeline page.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Try to improve go-gitea#28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…go-gitea#29203)

Relates to go-gitea#28654, go-gitea#29039 and go-gitea#29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown.
So they should also be loaded when (un)resolving a conversation on the
timeline page.
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ux How users interact with Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The code comment dispeared after resolving/unresolving a comment
4 participants