Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass es2020 to esbuild-loader as well #29027

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Pass es2020 to esbuild-loader as well #29027

merged 1 commit into from
Feb 2, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 2, 2024 •
edited
Loading

Followup #28977. I forgot to pass the updated option to esbuild-loader, e.g. previously it was only passed to the minifier.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2024
@silverwind silverwind added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2024
@silverwind silverwind merged commit 8f9f0e4 into go-gitea:main Feb 2, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 2, 2024
@silverwind silverwind deleted the 2020 branch February 2, 2024 14:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bafab25 
* giteaofficial/main:
  Add `must-change-password` cli parameter (go-gitea#27626)
  Include username in email headers (go-gitea#28981)
  Update tool dependencies (go-gitea#29030)
  Add artifacts v4 jwt to job message and accept it (go-gitea#28885)
  Pass es2020 to esbuild-loader as well (go-gitea#29027)
  Fix default avatar image size in PR diff page (go-gitea#28971)
  Update JS and PY dependencies, build for `es2020` browsers (go-gitea#28977)
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@silverwind
Pass es2020 to esbuild-loader as well (go-gitea#29027)
9d66903 
Followup go-gitea#28977. I forgot to pass
the updated option to esbuild-loader, e.g. previously it was only passed
to the minifier.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @lunny @yardenshoham @GiteaBot