Don't remove all mirror repository's releases when mirroring #28817

lunny · 2024-01-16T14:31:20Z

Fix #22066

Purpose

This PR fix the releases will be deleted when mirror repository sync the tags.

The problem

In the previous implementation of #19125. All releases record in databases of one mirror repository will be deleted before sync.
Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481

The Pros

This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts.

The Cons

The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory.

wxiaoguang

(outdated)

~~Although I was requested for reviewing, but: no test, no comment, no description, so no idea how to review.~~

lunny · 2024-01-17T02:05:21Z

Although I was requested for reviewing, but: no test, no comment, no description, so no idea how to review.

Sorry. I have reverted unnecessary refactor changes and also added a unit test. Please review it again.

6543 · 2024-01-25T23:17:43Z

modules/repository/repo_test.go

+ assert.EqualValues(t, 1, len(inserts), "inserts")
+ assert.EqualValues(t, *gitTags[2], *inserts[0], "inserts equal")


Suggested change

assert.EqualValues(t, 1, len(inserts), "inserts")

assert.EqualValues(t, *gitTags[2], *inserts[0], "inserts equal")

if assert.EqualLen(t, inserts, 1) {

assert.EqualValues(t, *gitTags[2], *inserts[0], "inserts equal")

}

I don't think we have to do this since it's just testing. If it panics, just let it panic.

modules/repository/repo_test.go

…a#28817) Fix go-gitea#22066 # Purpose This PR fix the releases will be deleted when mirror repository sync the tags. # The problem In the previous implementation of go-gitea#19125. All releases record in databases of one mirror repository will be deleted before sync. Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481 # The Pros This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts. # The Cons The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory.

* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix bug for generated repository object format (go-gitea#28969) Fixing small space missing in sample config file (go-gitea#28967) Fix inconsistent naming of OAuth 2.0 `ENABLE` setting (go-gitea#28951) Add screenshot for "Profile Readmes" to docs (go-gitea#28964) Simplify how git repositories are opened (go-gitea#28937) Preserve BOM in web editor (go-gitea#28935) Make loading animation less aggressive (go-gitea#28955) Fix SSPI user creation (go-gitea#28948) Strip `/` from relative links (go-gitea#28932) Fix non-alphabetic sorting of repo topics (go-gitea#28938) Don't remove all mirror repository's releases when mirroring (go-gitea#28817) Use new RPM constants (go-gitea#28931) Check for sha256 support to use --object-format flag (go-gitea#28928) fix: update enable_prune even if mirror_interval is not provided (go-gitea#28905) Implement `MigrateRepository` for the actions notifier (go-gitea#28920) Respect branch info for relative links (go-gitea#28909)

…a#28817) Fix go-gitea#22066 # Purpose This PR fix the releases will be deleted when mirror repository sync the tags. # The problem In the previous implementation of go-gitea#19125. All releases record in databases of one mirror repository will be deleted before sync. Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481 # The Pros This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts. # The Cons The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory.

@lunny

…#28939) Backport #28817 by @lunny Fix #22066 # Purpose This PR fix the releases will be deleted when mirror repository sync the tags. # The problem In the previous implementation of #19125. All releases record in databases of one mirror repository will be deleted before sync. Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481 # The Pros This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts. # The Cons The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory. --------- Co-authored-by: Lunny Xiao <[email protected]>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.21.4` -> `1.21.5` | --- ### Release Notes <details> <summary>go-gitea/gitea (docker.io/gitea/gitea)</summary> ### [`v1.21.5`](https://github.com/go-gitea/gitea/releases/tag/v1.21.5) [Compare Source](go-gitea/gitea@v1.21.4...v1.21.5) - SECURITY - Prevent anonymous container access if `RequireSignInView` is enabled ([#28877](go-gitea/gitea#28877)) ([#28882](go-gitea/gitea#28882)) - Update go dependencies and fix go-git ([#28893](go-gitea/gitea#28893)) ([#28934](go-gitea/gitea#28934)) - BUGFIXES - Revert "Speed up loading the dashboard on mysql/mariadb ([#28546](go-gitea/gitea#28546))" ([#29006](go-gitea/gitea#29006)) ([#29007](go-gitea/gitea#29007)) - Fix an actions schedule bug ([#28942](go-gitea/gitea#28942)) ([#28999](go-gitea/gitea#28999)) - Fix update enable_prune even if mirror_interval is not provided ([#28905](go-gitea/gitea#28905)) ([#28929](go-gitea/gitea#28929)) - Fix uploaded artifacts should be overwritten ([#28726](go-gitea/gitea#28726)) backport v1.21 ([#28832](go-gitea/gitea#28832)) - Preserve BOM in web editor ([#28935](go-gitea/gitea#28935)) ([#28959](go-gitea/gitea#28959)) - Strip `/` from relative links ([#28932](go-gitea/gitea#28932)) ([#28952](go-gitea/gitea#28952)) - Don't remove all mirror repository's releases when mirroring ([#28817](go-gitea/gitea#28817)) ([#28939](go-gitea/gitea#28939)) - Implement `MigrateRepository` for the actions notifier ([#28920](go-gitea/gitea#28920)) ([#28923](go-gitea/gitea#28923)) - Respect branch info for relative links ([#28909](go-gitea/gitea#28909)) ([#28922](go-gitea/gitea#28922)) - Don't reload timeline page when (un)resolving or replying conversation ([#28654](go-gitea/gitea#28654)) ([#28917](go-gitea/gitea#28917)) - Only migrate the first 255 chars of a Github issue title ([#28902](go-gitea/gitea#28902)) ([#28912](go-gitea/gitea#28912)) - Fix sort bug on repository issues list ([#28897](go-gitea/gitea#28897)) ([#28901](go-gitea/gitea#28901)) - Fix `DeleteCollaboration` transaction behaviour ([#28886](go-gitea/gitea#28886)) ([#28889](go-gitea/gitea#28889)) - Fix schedule not trigger bug because matching full ref name with short ref name ([#28874](go-gitea/gitea#28874)) ([#28888](go-gitea/gitea#28888)) - Fix migrate storage bug ([#28830](go-gitea/gitea#28830)) ([#28867](go-gitea/gitea#28867)) - Fix archive creating LFS hooks and breaking pull requests ([#28848](go-gitea/gitea#28848)) ([#28851](go-gitea/gitea#28851)) - Fix reverting a merge commit failing ([#28794](go-gitea/gitea#28794)) ([#28825](go-gitea/gitea#28825)) - Upgrade xorm to v1.3.7 to fix a resource leak problem caused by Iterate ([#28891](go-gitea/gitea#28891)) ([#28895](go-gitea/gitea#28895)) - Fix incorrect PostgreSQL connection string for Unix sockets ([#28865](go-gitea/gitea#28865)) ([#28870](go-gitea/gitea#28870)) - ENHANCEMENTS - Make loading animation less aggressive ([#28955](go-gitea/gitea#28955)) ([#28956](go-gitea/gitea#28956)) - Avoid duplicate JS error messages on UI ([#28873](go-gitea/gitea#28873)) ([#28881](go-gitea/gitea#28881)) - Bump `@github/relative-time-element` to 4.3.1 ([#28819](go-gitea/gitea#28819)) ([#28826](go-gitea/gitea#28826)) - MISC - Warn that `DISABLE_QUERY_AUTH_TOKEN` is false only if it's explicitly defined ([#28783](go-gitea/gitea#28783)) ([#28868](go-gitea/gitea#28868)) - Remove duplicated checkinit on git module ([#28824](go-gitea/gitea#28824)) ([#28831](go-gitea/gitea#28831)) Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/355 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

…a#28817) Fix go-gitea#22066 # Purpose This PR fix the releases will be deleted when mirror repository sync the tags. # The problem In the previous implementation of go-gitea#19125. All releases record in databases of one mirror repository will be deleted before sync. Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481 # The Pros This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts. # The Cons The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory.

Don't remove all mirror repository's releases when mirroring

1006e6e

lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Jan 16, 2024

lunny added this to the 1.22.0 milestone Jan 16, 2024

lunny requested a review from wxiaoguang January 16, 2024 14:31

GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2024

pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 16, 2024

github-actions bot added the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Jan 16, 2024

lunny mentioned this pull request Jan 16, 2024

Releases are deleted when mirror repository is synchronized #22066

Closed

lunny added 2 commits January 17, 2024 00:41

Fix bug

bbdb7df

Merge branch 'main' into lunny/improve_mirror_tags

a514714

wxiaoguang reviewed Jan 16, 2024

View reviewed changes

lunny added 2 commits January 17, 2024 09:47

revert refactor change

53ab18d

Merge branch 'main' into lunny/improve_mirror_tags

244758d

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2024

github-actions bot removed the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Jan 17, 2024

Add unit test for new introduced function

8c76856

pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024

lunny added 2 commits January 17, 2024 10:10

use a simple struct to reduce possible memory

578c65b

Fix bug

6d7d21d

wxiaoguang approved these changes Jan 17, 2024

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2024

lunny added the pr/last-call This PR has been stale for too long. If no one reviewes it within a week, it will be closed. label Jan 24, 2024

6543 reviewed Jan 25, 2024

View reviewed changes

modules/repository/repo_test.go Outdated Show resolved Hide resolved

wolfogre approved these changes Jan 26, 2024

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2024

lunny added 2 commits January 26, 2024 13:53

Follow 6543's suggestion

9ee6782

Merge branch 'main' into lunny/improve_mirror_tags

212480b

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 26, 2024

lunny enabled auto-merge (squash) January 26, 2024 05:54

lunny merged commit 534917d into go-gitea:main Jan 26, 2024
25 checks passed

GiteaBot mentioned this pull request Jan 26, 2024

Don't remove all mirror repository's releases when mirroring (#28817) #28939

Merged

GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. pr/last-call This PR has been stale for too long. If no one reviewes it within a week, it will be closed. labels Jan 26, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't remove all mirror repository's releases when mirroring #28817

Don't remove all mirror repository's releases when mirroring #28817

lunny commented Jan 16, 2024 •

edited

Loading

wxiaoguang left a comment •

edited

Loading

lunny commented Jan 17, 2024

6543 Jan 25, 2024

wolfogre Jan 26, 2024

		assert.EqualValues(t, 1, len(inserts), "inserts")
		assert.EqualValues(t, gitTags[2], inserts[0], "inserts equal")

Don't remove all mirror repository's releases when mirroring #28817

Don't remove all mirror repository's releases when mirroring #28817

Conversation

lunny commented Jan 16, 2024 • edited Loading

Purpose

The problem

The Pros

The Cons

wxiaoguang left a comment • edited Loading

Choose a reason for hiding this comment

lunny commented Jan 17, 2024

6543 Jan 25, 2024

Choose a reason for hiding this comment

wolfogre Jan 26, 2024

Choose a reason for hiding this comment

lunny commented Jan 16, 2024 •

edited

Loading

wxiaoguang left a comment •

edited

Loading