Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont load Review if Comment is CommentTypeReviewRequest #28551

Merged
merged 17 commits into from
Feb 13, 2024
Merged

Dont load Review if Comment is CommentTypeReviewRequest #28551

merged 17 commits into from
Feb 13, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 20, 2023 •
edited
Loading

RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out #28544

@6543 6543 added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 20, 2023
@6543 6543 requested a review from lunny December 20, 2023 10:57
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@6543 6543 changed the title RequestReview get deleted on review. So we dont have to try to load t… Dont load Review if Comment is CommentTypeReviewRequest Dec 20, 2023
@6543 6543 modified the milestones: 1.21.3, 1.22.0 Dec 20, 2023
@6543 6543 mentioned this pull request Dec 20, 2023
Open
6 tasks
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
delvh
delvh reviewed Dec 30, 2023
View reviewed changes
models/issues/review.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 30, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2024
@6543 6543 requested a review from wxiaoguang January 13, 2024 01:44
wxiaoguang
wxiaoguang reviewed Jan 13, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #28551 (comment)

@6543 6543 requested a review from a team February 12, 2024 21:18
6543
6543 commented Feb 12, 2024
View reviewed changes
models/issues/comment_list.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2024
@6543 6543 merged commit 6fad2c8 into go-gitea:main Feb 13, 2024
26 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @6543, please send one manually. 🍵

go run ./contrib/backport 28551
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 13, 2024
@6543 6543 deleted the no_error-when-notfound-is-expected branch February 13, 2024 08:45
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 13, 2024
@6543
Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
703c80e 
RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out go-gitea#28544
@6543 6543 mentioned this pull request Feb 13, 2024
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Feb 13, 2024
@6543
Copy link
Member Author

6543 commented Feb 13, 2024

-> #29160

silverwind pushed a commit that referenced this pull request Feb 13, 2024
@6543
Dont load Review if Comment is CommentTypeReviewRequest (#28551) (#29160
0ac3186 
)

Backport #28551

RequestReview get deleted on review.
So we don't have to try to load them on comments.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
82aedae 
* giteaofficial/main: (38 commits)
  Document how the TOC election process works (go-gitea#29135)
  Runner tokens are multi use (go-gitea#29153)
  Fix Gitpod logic of setting ROOT_URL (go-gitea#29162)
  Remove jQuery from the user search form in admin page (go-gitea#29151)
  Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
  Show `View at this point in history` for every commit (go-gitea#29122)
  [skip ci] Updated translations via Crowdin
  Add merge style `fast-forward-only` (go-gitea#28954)
  Use Markdown alert syntax for notes in README (go-gitea#29150)
  Refactor issue template parsing and fix API endpoint (go-gitea#29069)
  [skip ci] Updated translations via Crowdin
  Update some translations and fix markdown formatting (go-gitea#29099)
  Show more settings for empty repositories (go-gitea#29130)
  Update JS and PY dependencies (go-gitea#29127)
  Add alert blocks in markdown (go-gitea#29121)
  Remove obsolete border-radius on comment content (go-gitea#29128)
  Make blockquote border size less aggressive (go-gitea#29124)
  Drop "@" from email sender to avoid spam filters (go-gitea#29109)
  [skip ci] Updated translations via Crowdin
  Disallow duplicate storage paths (go-gitea#26484)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 15, 2024
@6543 @silverwind
Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
70ecb18 
RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out go-gitea#28544
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@6543 @silverwind
Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
51d756e 
RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out go-gitea#28544
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@6543 @earl-warren
Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
e9e6c61 
RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out go-gitea#28544

(cherry picked from commit 6fad2c8)
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @GiteaBot @lunny @silverwind @wxiaoguang @delvh