Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DownloadFunc when migrating releases #27887

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Fix DownloadFunc when migrating releases #27887

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
857ec23
fix asset.ID in DownloadFunc closure
Zettat123 Nov 3, 2023
0d25f2a
fix asset.ID in log
Zettat123 Nov 3, 2023
68050f6
fix download url
Zettat123 Nov 3, 2023
1821700
Merge branch 'main' into fix-migration-release
lunny Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix asset.ID in log
  • Loading branch information
@Zettat123
Zettat123 committed Nov 3, 2023
commit 0d25f2a192f0bd34fd6bcf2fc0db10fcdcdd648b
2 changes: 1 addition & 1 deletion services/migrations/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ func (g *GitlabDownloader) convertGitlabRelease(rel *gitlab.Release) *base.Relea
}

if !hasBaseURL(link.URL, g.baseURL) {
WarnAndNotice("Unexpected AssetURL for assetID[%d] in %s: %s", asset.ID, g, link.URL)
WarnAndNotice("Unexpected AssetURL for assetID[%d] in %s: %s", assetID, g, link.URL)
return io.NopCloser(strings.NewReader(link.URL)), nil
}

Expand Down