Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve feed icons and feed merge text color #27498

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Improve feed icons and feed merge text color #27498

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d2815f
Improve feed icons and feed merge text color
silverwind Oct 7, 2023
1dc2021
use x for ActionDeleteBranch
silverwind Oct 7, 2023
051ccf3
Revert "use x for ActionDeleteBranch"
silverwind Oct 7, 2023
f564d8c
Merge branch 'main' into feed1
GiteaBot Oct 7, 2023
8dcb49b
Merge branch 'main' into feed1
GiteaBot Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use x for ActionDeleteBranch
  • Loading branch information
@silverwind
silverwind committed Oct 7, 2023
commit 1dc20219f8c676d31e8be7c7d710db14d57fa71c
4 changes: 1 addition & 3 deletions modules/templates/util_misc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ func ActionIcon(opType activities_model.ActionType) string {
return "repo"
case activities_model.ActionCommitRepo:
return "git-commit"
case activities_model.ActionDeleteBranch:
return "git-branch"
case activities_model.ActionMergePullRequest, activities_model.ActionAutoMergePullRequest:
return "git-merge"
case activities_model.ActionCreatePullRequest:
Expand All @@ -100,7 +98,7 @@ func ActionIcon(opType activities_model.ActionType) string {
return "file-diff"
case activities_model.ActionPublishRelease, activities_model.ActionPushTag, activities_model.ActionDeleteTag:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimally, there would be a tag deleted icon, but I think if anything, we have to suggest that upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same could be said about branch deletion. Not sure if it would be accepted upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean… I don't know why it shouldn't.
The only reasoning I can see is that no one has the time to implement it, but apart from that there's nothing speaking against it as it is needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.
grafik

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will accept a resonably articulated feedback type issue I assume.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add to this, they do... Once gave feedback on the site and they implemented it eventually... Tho, it can take a long time to be implemented (And I recall using bug report, but I assume the feedback one may work as well)

return "tag"
case activities_model.ActionPullReviewDismissed:
case activities_model.ActionPullReviewDismissed, activities_model.ActionDeleteBranch:
return "x"
default:
return "question"
Expand Down
Loading