-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix successful return value for SyncAndGetUserSpecificDiff
#27152
Merged
delvh
merged 2 commits into
go-gitea:main
from
delvh:bugfix/really-ignore-ignored-error
Sep 20, 2023
Merged
Fix successful return value for SyncAndGetUserSpecificDiff
#27152
delvh
merged 2 commits into
go-gitea:main
from
delvh:bugfix/really-ignore-ignored-error
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error was already supposed to be ignored but alas, it wasn't properly ignored.
SyncAndGetUserSpecificDiff
SyncAndGetUserSpecificDiff
properly
Line 1347 should be |
True, that makes even more sense. |
SyncAndGetUserSpecificDiff
properlySyncAndGetUserSpecificDiff
wxiaoguang
approved these changes
Sep 20, 2023
lunny
approved these changes
Sep 20, 2023
Thank you for taking the bug report on chat. Unfortunately it isn't trivial for me to check if this fixes the problem |
@GiteaBot ping? |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 20, 2023
…a#27152) A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen…
silverwind
pushed a commit
that referenced
this pull request
Sep 20, 2023
…#27156) Backport #27152 by @delvh A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen… Co-authored-by: delvh <[email protected]>
You can use the 1.20 nightly build, it is trivial. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Sep 21, 2023
* origin/main: Fix dropdown icon position (go-gitea#27175) Fix repo sub menu (go-gitea#27169) Fix review request number and add more tests (go-gitea#27104) Fix the variable regexp pattern on web page (go-gitea#27161) Fix organization field being null in POST /orgs/{orgid}/teams (go-gitea#27150) Add index to `issue_user.issue_id` (go-gitea#27154) [skip ci] Updated translations via Crowdin Start development on Gitea 1.22 (go-gitea#27155) Fix successful return value for `SyncAndGetUserSpecificDiff` (go-gitea#27152) Improve actions docs related to `pull_request` event (go-gitea#27126) Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119) Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124) Fix incorrect test code for error handling (go-gitea#27139) Increase auth provider icon size on login page (go-gitea#27122) fix pagination for followers and following (go-gitea#27127) services/wiki: Close() after error handling (go-gitea#27129) Use fetch helpers instead of fetch (go-gitea#27026) Change green buttons to primary color (go-gitea#27099) Fix wrong xorm get usage on migration (go-gitea#27111)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 22, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Updates to the API for archived repos (go-gitea#27149) Fix release URL in webhooks (go-gitea#27182) Fix dropdown icon position (go-gitea#27175) Fix repo sub menu (go-gitea#27169) Fix review request number and add more tests (go-gitea#27104) Fix the variable regexp pattern on web page (go-gitea#27161) Fix organization field being null in POST /orgs/{orgid}/teams (go-gitea#27150) Add index to `issue_user.issue_id` (go-gitea#27154) [skip ci] Updated translations via Crowdin Start development on Gitea 1.22 (go-gitea#27155) Fix successful return value for `SyncAndGetUserSpecificDiff` (go-gitea#27152)
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 4, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.20.4` -> `1.20.5` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>go-gitea/gitea (docker.io/gitea/gitea)</summary> ### [`v1.20.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1205---2023-10-03) [Compare Source](go-gitea/gitea@v1.20.4...v1.20.5) - ENHANCEMENTS - Fix z-index on markdown completion ([#​27237](go-gitea/gitea#27237)) ([#​27242](go-gitea/gitea#27242) & [#​27238](go-gitea/gitea#27238)) - Use secure cookie for HTTPS sites ([#​26999](go-gitea/gitea#26999)) ([#​27013](go-gitea/gitea#27013)) - BUGFIXES - Fix git 2.11 error when checking IsEmpty ([#​27393](go-gitea/gitea#27393)) ([#​27396](go-gitea/gitea#27396)) - Allow get release download files and lfs files with oauth2 token format ([#​26430](go-gitea/gitea#26430)) ([#​27378](go-gitea/gitea#27378)) - Fix orphan check for deleted branch ([#​27310](go-gitea/gitea#27310)) ([#​27320](go-gitea/gitea#27320)) - Quote table `release` in sql queries ([#​27205](go-gitea/gitea#27205)) ([#​27219](go-gitea/gitea#27219)) - Fix release URL in webhooks ([#​27182](go-gitea/gitea#27182)) ([#​27184](go-gitea/gitea#27184)) - Fix successful return value for `SyncAndGetUserSpecificDiff` ([#​27152](go-gitea/gitea#27152)) ([#​27156](go-gitea/gitea#27156)) - fix pagination for followers and following ([#​27127](go-gitea/gitea#27127)) ([#​27138](go-gitea/gitea#27138)) - Fix issue templates when blank isses are disabled ([#​27061](go-gitea/gitea#27061)) ([#​27082](go-gitea/gitea#27082)) - Fix context cache bug & enable context cache for dashabord commits' authors([#​26991](go-gitea/gitea#26991)) ([#​27017](go-gitea/gitea#27017)) - Fix INI parsing for value with trailing slash ([#​26995](go-gitea/gitea#26995)) ([#​27001](go-gitea/gitea#27001)) - Fix PushEvent NullPointerException jenkinsci/github-plugin ([#​27203](go-gitea/gitea#27203)) ([#​27249](go-gitea/gitea#27249)) - Fix organization field being null in POST /orgs/{orgid}/teams ([#​27150](go-gitea/gitea#27150)) ([#​27167](go-gitea/gitea#27167) & [#​27162](go-gitea/gitea#27162)) - Fix bug of review request number ([#​27406](go-gitea/gitea#27406)) ([#​27104](go-gitea/gitea#27104)) - TESTING - services/wiki: Close() after error handling ([#​27129](go-gitea/gitea#27129)) ([#​27137](go-gitea/gitea#27137)) - DOCS - Improve actions docs related to `pull_request` event ([#​27126](go-gitea/gitea#27126)) ([#​27145](go-gitea/gitea#27145)) - MISC - Add logs for data broken of comment review ([#​27326](go-gitea/gitea#27326)) ([#​27344](go-gitea/gitea#27344)) - Load reviewer before sending notification ([#​27063](go-gitea/gitea#27063)) ([#​27064](go-gitea/gitea#27064)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/129 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.20
This PR should be backported to Gitea 1.20
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function should not return an error when it is successful.
Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen…