-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show total TrackedTime on issue/pull/milestone lists #26672
Show total TrackedTime on issue/pull/milestone lists #26672
Conversation
make function name more descriptive as it would otherwise imply it could be used for e.g. #26672 too ... --- *Sponsored by Kithara Software GmbH*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies if I've missed it, but could you add a conditional that if time tracking is disabled, then the query isn't run?
uh sure! |
@techknowlogick done |
This PR looks good, but I don't use time tracking so probably best if someone else more familiar with the usage of time tracking should review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is the place of this in the issue list because the header is already pretty cramped. I guess I can accept this for now, but I think it might be later better moved below the list, bottom-right, if we have more such "summary" style stuff.
* upstream/main: Adapt `.changelog.yml` to new labeling system (go-gitea#27701) Update and add new eslint plugins (go-gitea#27698) Show total TrackedTime on issue/pull/milestone lists (go-gitea#26672) Add doctor dbconsistency fix to delete repos with no owner (go-gitea#27290) Delete repos of org when purge delete user (go-gitea#27273) Fix required checkboxes in issue forms (go-gitea#27592) Upgrade xorm (go-gitea#27673) [docs] Add note that PROTOCOL config is case-sensitive (go-gitea#25685) Remove network call on `make clean` (go-gitea#27689) Add unit tests for action runner token (go-gitea#27670) Typos fixed in documentation files (go-gitea#27687)
TODOs:
GetIssueTotalTrackedTime
Sponsored by Kithara Software GmbH