Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass 6-digit hex color to monaco (#25780) #25782

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Always pass 6-digit hex color to monaco (#25780) #25782

merged 1 commit into from
Jul 9, 2023

Commits on Jul 9, 2023

  1. Always pass 6-digit hex color to monaco (go-gitea#25780) 

    Monaco can not deal with color formats other than 6-digit hex, so we
convert the colors for it via new
[`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB
minzipped).

Also, with the addition of the module, we can replace the existing
`hexToRGBColor` usage, I verified it is compatible with the current
tests before removing the function.

Fixes: go-gitea#25770
    @silverwind
    silverwind committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    7935834 View commit details
    Browse the repository at this point in the history