Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite the log mode when installing #25203

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Do not overwrite the log mode when installing #25203

merged 4 commits into from
Jun 12, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #24861

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2023
@wxiaoguang wxiaoguang mentioned this pull request Jun 12, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2023
@delvh
Copy link
Member

delvh commented Jun 12, 2023

Which branches should we backport this to?
1.20?
1.19 as well?

@wxiaoguang
Copy link
Contributor Author

Only 1.20.

1.19 still needs cfg.Section("log").Key("ROUTER").SetValue("console")

@delvh delvh added the backport/v1.20 This PR should be backported to Gitea 1.20 label Jun 12, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2023
@lunny lunny enabled auto-merge (squash) June 12, 2023 09:29
@lunny lunny merged commit eaf551b into go-gitea:main Jun 12, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 12, 2023
@GiteaBot GiteaBot mentioned this pull request Jun 12, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 12, 2023
@wxiaoguang @GiteaBot
Do not overwrite the log mode when installing (go-gitea#25203)
8674fcb 
Fix go-gitea#24861
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 12, 2023
@wxiaoguang wxiaoguang deleted the fix-install-log-mode branch June 12, 2023 10:53
silverwind pushed a commit that referenced this pull request Jun 13, 2023
@GiteaBot @wxiaoguang
Do not overwrite the log mode when installing (#25203) (#25209)
fa28d0e 
Backport #25203 by @wxiaoguang

Fix #24861

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang wxiaoguang mentioned this pull request Jun 29, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/deployment type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Log mode changed to console after installation
4 participants
@wxiaoguang @delvh @lunny @GiteaBot