Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link to Stars and Forks Page to Repo List #24931

Merged
merged 5 commits into from
May 25, 2023

Conversation

JakobDev
Copy link
Contributor

The Repolist contains the Number of Stars and Forks. Now these Numbers are a Link to the corresponding pages of the Repo.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2023
@silverwind
Copy link
Member

Any screenshot? Does it need muted?

@delvh delvh added this to the 1.20.0 milestone May 25, 2023
@delvh
Copy link
Member

delvh commented May 25, 2023

focused:
image
hovered:
image

Does it need muted?

I guess not?

@silverwind
Copy link
Member

Yeah that's fine, some other style must already be setting the color there.

@JakobDev
Copy link
Contributor Author

Any screenshot?

It looks exactly the same as previous. Nothing changed here.

@wxiaoguang
Copy link
Contributor

Any screenshot? Does it need muted?

As we discussed before, if the a are all muted by default, then no need to worry about new PRs ....

@silverwind
Copy link
Member

silverwind commented May 25, 2023

Yes, muting links be default may be worth considering given that we now have muted almost all of them already. For the rare case we want color, we could have a unmute class 😆.

@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 25, 2023
@silverwind silverwind enabled auto-merge (squash) May 25, 2023 15:35
@silverwind silverwind merged commit 1ef0fda into go-gitea:main May 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 25, 2023
@JakobDev JakobDev deleted the startforklink branch May 25, 2023 17:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 26, 2023
* upstream/main:
  Use the type RefName for all the needed places and fix pull mirror sync bugs (go-gitea#24634)
  [skip ci] Updated translations via Crowdin
  Add Link to Stars and Forks Page to Repo List (go-gitea#24931)
  Fix documentation ref (go-gitea#24934)
  Add Chinese docs for help, contribution and development (go-gitea#24925)
  Merge two translation contributing documents (go-gitea#23939)
  Add the ability to pin Issues (go-gitea#24406)
  Use `shared/issueicon` template in projects (go-gitea#24922)
  Allow skipping forks and mirrors from being indexed (go-gitea#23187)
  Add Chinese documentations for Actions (go-gitea#24902)

# Conflicts:
#	templates/repo/issue/view_content/sidebar.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants