Override alias template to preserve anchor fragment #24394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
jolheiser
added
type/docs
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
techknowlogick
approved these changes
Apr 28, 2023
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Apr 28, 2023
delvh
approved these changes
Apr 28, 2023
GiteaBot
added
lgtm/done
Co-authored-by: silverwind <[email protected]>
I can take a look and propose it upstream as well. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an annoyance where docs aliases aren't preserving their anchor fragments.
The refactor included aliases to keep old links from dying, but currently they redirect without their anchor, which was used often to jump to sections.
This overrides the alias template with an alternative that preserves the anchor fragment.
To note, this is just a copy of the embedded template, but defaults to a JS redirect that preserves the anchor, and uses the meta tag as a fallback for noscript users.
I've also preserved query params, but I can remove that if we don't think it's necessary.