-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint-plugin-regexp #24361
Merged
techknowlogick
merged 4 commits into
go-gitea:main
from
silverwind:eslint-plugin-regexp
Apr 27, 2023
Merged
Add eslint-plugin-regexp #24361
techknowlogick
merged 4 commits into
go-gitea:main
from
silverwind:eslint-plugin-regexp
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the changes you made have any consequences? ( |
No. Errors were:
The two flag cases where autofixed actually, the unescaped |
yardenshoham
approved these changes
Apr 26, 2023
delvh
reviewed
Apr 26, 2023
delvh
approved these changes
Apr 26, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 28, 2023
* giteaofficial/main: (26 commits) Refactor docs (go-gitea#23752) Fix layouts of admin table / adapt repo / email test (go-gitea#24370) Move secrets and runners settings to actions settings (go-gitea#24200) Gitea Actions add `base_ref`, `head_ref`, `api_url`, `ref_type` fields (go-gitea#24356) Fix auth check bug (go-gitea#24382) Display 'Unknown' when runner.version is empty (go-gitea#24378) Fix incorrect last online time in runner_edit.tmpl (go-gitea#24376) Refactor "route" related code, fix Safari cookie bug (go-gitea#24330) Add custom helm repo name generated from url (go-gitea#24363) Add API for gitignore templates (go-gitea#22783) Add eslint-plugin-regexp (go-gitea#24361) Support uploading file to empty repo by API (go-gitea#24357) [skip ci] Updated translations via Crowdin Require repo scope for PATs for private repos and basic authentication (go-gitea#24362) Alert error message if open dependencies are included in the issues that try to batch close (go-gitea#24329) Fix 404 error when leaving the last private org team (go-gitea#24322) Modify width of ui container, fine tune css for settings pages and org header (go-gitea#24315) Add .livemd as a markdown extension (go-gitea#22730) Display when a repo was archived (go-gitea#22664) Fix wrong error info in RepoRefForAPI (go-gitea#24344) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
topic/code-linting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
eslint-plugin-regexp
and fix discovered issues. Config is mostly the recommended one, but I relaxed a few rules.