Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve External Wiki in Repo Header #24304

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Improve External Wiki in Repo Header #24304

merged 4 commits into from
Apr 24, 2023

Conversation

JakobDev
Copy link
Contributor

If you use a External Wiki, with Gitea, it brings currently 2 Problems in the Header:

  1. It always uses the Wiki Icon. When you use e.g. a External Issue Tracker, it shows the External Link icon to Indicate, that the User will send to a External Side. This helps preventing fishing.
  2. If you use a External Wiki, the Link in the Header still goes to {repo}/wiki which will redirect the user to the External Wiki. That means, that if the users hovers with the Cursor over the link, it shows {repo}/wiki, so the User does not know, where he will land.

This PR fixes both.

grafik

@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 24, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@jolheiser jolheiser enabled auto-merge (squash) April 24, 2023 15:44
@jolheiser jolheiser merged commit d347208 into go-gitea:main Apr 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@JakobDev JakobDev deleted the externalwiki branch April 24, 2023 17:19
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0a90017 
* giteaofficial/main:
  default show closed actions list if all actions was closed (go-gitea#24234)
  [skip ci] Updated translations via Crowdin
  update nightly drone docker tag (go-gitea#24311)
  Remove org users who belong to no teams (go-gitea#24247)
  Fix typo in API route (go-gitea#24310)
  Add --font-weight-bold and set previous bold to 601 (go-gitea#24307)
  Mark `/templates/swagger/v1_json.tmpl` as generated file (go-gitea#24306)
  Improve External Wiki in Repo Header (go-gitea#24304)
  Unify nightly naming across binaries and docker images (go-gitea#24116)
  Wrap too long push mirror addresses (go-gitea#21120)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobDev @wxiaoguang @yardenshoham @jolheiser @GiteaBot