-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use User.ID instead of User.Name in ActivityPub API for Person IRI #23823
Conversation
d25536b
to
6247384
Compare
…o-gitea#23823) Thanks to @trwnh Close go-gitea#23802 The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.
* upstream/main: Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823) Remove fomantic ".link" selector and styles (go-gitea#23888) [skip ci] Updated translations via Crowdin Fix `cases.Title` crash for concurrency (go-gitea#23885) Disable editing tags (go-gitea#23883) Fix user profile description rendering (go-gitea#23882) Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861) Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839) Fix review box viewport overflow issue (go-gitea#23800) Fix owner team access mode value in team_unit table (go-gitea#23675) Fix submit button won't refresh in New Repository Fork page (go-gitea#22994) Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876) Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736) Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734) Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733) Try to catch more broken translations (go-gitea#23867)
…23823) (#23905) Backport #23823 by @wxiaoguang Thanks to @trwnh Close #23802 The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name. Co-authored-by: wxiaoguang <[email protected]>
This is breaking and should not have been merged in to 1.20 or 1.19. The swagger description for the old path should have been kept in place and the new one added. You cannot just drop API at whim. |
Let's see if it breaks. If it breaks, I will fix. |
I don't think anyone was actually using these endpoints other than me for testing purposes so it's perfectly fine in my opinion that this change was made. |
Thanks to @trwnh
Close #23802
The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.