Use User.ID instead of User.Name in ActivityPub API for Person IRI #23823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
changed the title
lunny
approved these changes
Mar 30, 2023
GiteaBot
added
the
lgtm/need 1
wxiaoguang
force-pushed
the
fix-ap-user
branch
2 times, most recently
from
d25536b
to
6247384
Compare
lunny
added
type/bug
outdated/backport/v1.19
silverwind
approved these changes
Apr 3, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 4, 2023
…o-gitea#23823) Thanks to @trwnh Close go-gitea#23802 The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 4, 2023
* upstream/main: Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823) Remove fomantic ".link" selector and styles (go-gitea#23888) [skip ci] Updated translations via Crowdin Fix `cases.Title` crash for concurrency (go-gitea#23885) Disable editing tags (go-gitea#23883) Fix user profile description rendering (go-gitea#23882) Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861) Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839) Fix review box viewport overflow issue (go-gitea#23800) Fix owner team access mode value in team_unit table (go-gitea#23675) Fix submit button won't refresh in New Repository Fork page (go-gitea#22994) Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876) Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736) Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734) Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733) Try to catch more broken translations (go-gitea#23867)
jolheiser
pushed a commit
that referenced
this pull request
Apr 4, 2023
…23823) (#23905) Backport #23823 by @wxiaoguang Thanks to @trwnh Close #23802 The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name. Co-authored-by: wxiaoguang <[email protected]>
|
This is breaking and should not have been merged in to 1.20 or 1.19. The swagger description for the old path should have been kept in place and the new one added. You cannot just drop API at whim. |
|
Let's see if it breaks. If it breaks, I will fix. |
I don't think anyone was actually using these endpoints other than me for testing purposes so it's perfectly fine in my opinion that this change was made. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @trwnh
Close #23802
The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.