Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long name ui issues and label ui issue #23541

Merged
merged 7 commits into from
Mar 18, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Mar 17, 2023

This PR fixes some ui problems as mentioned in the two issues below.

  1. Long file path has no word break

Before

截屏2023-03-17 17 49 43

After

截屏2023-03-17 17 51 22

on mobile

截屏2023-03-17 17 51 15

  1. Texts in labels

Before

截屏2023-03-17 17 49 24

After

截屏2023-03-17 17 51 31

with two labels

截屏2023-03-17 17 51 53

In explore and star pages

截屏2023-03-17 18 25 00

截屏2023-03-17 18 25 09

  1. Long name repository on creating new fork page

Before

截屏2023-03-17 17 50 01

After

截屏2023-03-17 17 50 37

截屏2023-03-17 17 50 48

Closes #23535
Closes #23534

@HesterG HesterG changed the title Fix long name ui issues and label issue Fix long name ui issues and label ui issue Mar 17, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Mar 17, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Mar 17, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 17, 2023
@delvh
Copy link
Member

delvh commented Mar 17, 2023

should we backport to 1.19?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 18, 2023
@delvh
Copy link
Member

delvh commented Mar 18, 2023

🎺 🤖

@delvh delvh merged commit d42015e into go-gitea:main Mar 18, 2023
@delvh delvh removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 18, 2023
@HesterG HesterG deleted the fix-longname-labels branch March 20, 2023 01:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 20, 2023
* giteaofficial/main: (23 commits)
  Display the version of runner in the runner list (go-gitea#23490)
  Add `.patch` to `attachment.ALLOWED_TYPES` (go-gitea#23580)
  Sort Python package descriptors by version to mimic PyPI format (go-gitea#23550)
  Use `project.IconName` instead of repeated unreadable `if-else` chains (go-gitea#23538)
  Match api migration behavior to web behavior (go-gitea#23552)
  Fix dropdown icon misalignment when using fomantic icon (go-gitea#23558)
  Enable color for consistency checks diffs (go-gitea#23563)
  [skip ci] Updated translations via Crowdin
  Fix sticky header in diff view (go-gitea#23554)
  Fix some broken css (go-gitea#23560)
  Fix JS error on compare page (go-gitea#23551)
  Upgrade to npm lockfile v3 and explicitely set it (go-gitea#23561)
  Fix long name ui issues and label ui issue  (go-gitea#23541)
  Remove worker-loader (go-gitea#23548)
  [skip ci] Updated translations via Crowdin
  Return `repository` in npm package metadata endpoint (go-gitea#23539)
  Fix diff detail buttons wrapping, use tippy for review box (go-gitea#23271)
  Do not store user projects as organization projects (go-gitea#23353)
  Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (go-gitea#23513)
  Increase horizontal page padding (go-gitea#23507)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
6 participants