-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run status in action view page #23212
Add run status in action view page #23212
Conversation
Looks like the status icon is not aligned with the title. |
@lunny |
<SvgIcon name="octicon-check-circle-fill" size="20" class="green" v-if="run.status === 'success'"/> | ||
<SvgIcon name="octicon-clock" size="20" class="ui text yellow" v-else-if="run.status === 'waiting'"/> | ||
<SvgIcon name="octicon-meter" size="20" class="ui text yellow" class-name="job-status-rotate" v-else-if="run.status === 'running'"/> | ||
<SvgIcon name="octicon-x-circle-fill" size="20" class="red" v-else/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about separating a RunStatus
component that takes as parameter the status
(and perhaps others like size
and extraClasses
if we really need these differences)?
Then we automatically keep this one and the one below in sync…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both OK from me to keep that PR standalone or merge it into this one.
* giteaofficial/main: (28 commits) Update hacking-on-gitea-zh_cn documentation (go-gitea#23315) Fix broken code editor diff preview (go-gitea#23307) [skip ci] Updated translations via Crowdin Add context when rendering labels or emojis (go-gitea#23281) Change interactiveBorder to fix popup preview (go-gitea#23169) Improve the frontend guideline (go-gitea#23298) Scoped labels: set aria-disabled on muted Exclusive option for a11y (go-gitea#23306) Add basic documentation for labels, including scoped labels (go-gitea#23304) [skip ci] Updated translations via Crowdin Re-add accidentally removed `hacking-on-gitea.zh-cn.md` (go-gitea#23297) Add default owner team to privated_org and limited_org in unit test (go-gitea#23109) Improve sed detection in update-locales.sh (go-gitea#23254) Support sanitising the URL by removing extra slashes in the URL (go-gitea#21333) Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (go-gitea#23245) Avoid panic caused by broken payload when creating commit status (go-gitea#23216) Add run status in action view page (go-gitea#23212) update to mermaid v10 (go-gitea#23178) Fix code wrap for unbroken lines (go-gitea#23268) Fix stray backticks appearing in pull request timeline (go-gitea#23282) Fill head commit to in payload when notifying push commits for mirroring (go-gitea#23215) ...
Related to: #23212 (comment) Decrease duplication of SvgIcon when display a run status svg. --------- Co-authored-by: Lunny Xiao <[email protected]>
I was unable to create a backport for 1.19, please send one manually. 🍵 |
Please remove |
I was unable to create a backport for 1.19. @yp05327, please send one manually. 🍵 |
@yardenshoham what is the correct method to prevent re-addition of |
Seems like adding |
Yes, if you manually create a backport you should add |
Before:
![image](https://user-images.githubusercontent.com/18380374/222084932-a7643fbe-2d9f-48db-b25d-74ace49e03f4.png)
![image](https://user-images.githubusercontent.com/18380374/222084887-fde3500d-dad3-4902-9c82-c4f71f23f83b.png)
After:
![image](https://user-images.githubusercontent.com/18380374/222084565-eeef1110-9d9d-40b4-a26b-fbd5a307f14e.png)
![image](https://user-images.githubusercontent.com/18380374/222084728-6c96d7c1-a399-43d5-8369-392ad5017b7f.png)