Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run status in action view page #23212

Merged
merged 4 commits into from
Mar 4, 2023
Merged

Add run status in action view page #23212

merged 4 commits into from
Mar 4, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 1, 2023

Before:
image
image

After:
image
image

@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI topic/gitea-actions related to the actions of Gitea labels Mar 1, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 1, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2023
@lunny
Copy link
Member

lunny commented Mar 2, 2023

Looks like the status icon is not aligned with the title.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 2, 2023

Looks like the status icon is not aligned with the title.

@lunny
It looks good now.
image

delvh
delvh reviewed Mar 2, 2023
View reviewed changes
web_src/js/components/RepoActionView.vue
Comment on lines +5 to +8
<SvgIcon name="octicon-check-circle-fill" size="20" class="green" v-if="run.status === 'success'"/>
<SvgIcon name="octicon-clock" size="20" class="ui text yellow" v-else-if="run.status === 'waiting'"/>
<SvgIcon name="octicon-meter" size="20" class="ui text yellow" class-name="job-status-rotate" v-else-if="run.status === 'running'"/>
<SvgIcon name="octicon-x-circle-fill" size="20" class="red" v-else/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about separating a RunStatus component that takes as parameter the status (and perhaps others like size and extraClasses if we really need these differences)?
Then we automatically keep this one and the one below in sync…

Copy link
Contributor Author

@yp05327 yp05327 Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. How about merge this PR first, and I will try to do this in another PR.

PS: It seems that SvgIcon are not used in:
image
image
Are these codes removable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delvh
#23259
I created a new PR to do this. I can merge it to this PR, if it looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both OK from me to keep that PR standalone or merge it into this one.

@yp05327 yp05327 mentioned this pull request Mar 3, 2023
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2023
@techknowlogick techknowlogick merged commit ca84a61 into go-gitea:main Mar 4, 2023
@techknowlogick techknowlogick added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 4, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 6, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
306ba96 
* giteaofficial/main: (28 commits)
  Update hacking-on-gitea-zh_cn documentation (go-gitea#23315)
  Fix broken code editor diff preview (go-gitea#23307)
  [skip ci] Updated translations via Crowdin
  Add context when rendering labels or emojis (go-gitea#23281)
  Change interactiveBorder to fix popup preview  (go-gitea#23169)
  Improve the frontend guideline (go-gitea#23298)
  Scoped labels: set aria-disabled on muted Exclusive option for a11y (go-gitea#23306)
  Add basic documentation for labels, including scoped labels (go-gitea#23304)
  [skip ci] Updated translations via Crowdin
  Re-add accidentally removed `hacking-on-gitea.zh-cn.md` (go-gitea#23297)
  Add default owner team to privated_org and limited_org in unit test (go-gitea#23109)
  Improve sed detection in update-locales.sh (go-gitea#23254)
  Support sanitising the URL by removing extra slashes in the URL (go-gitea#21333)
  Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (go-gitea#23245)
  Avoid panic caused by broken payload when creating commit status (go-gitea#23216)
  Add run status in action view page (go-gitea#23212)
  update to mermaid v10 (go-gitea#23178)
  Fix code wrap for unbroken lines (go-gitea#23268)
  Fix stray backticks appearing in pull request timeline (go-gitea#23282)
  Fill head commit to in payload when notifying push commits for mirroring (go-gitea#23215)
  ...
lunny added a commit that referenced this pull request Mar 6, 2023
@yp05327 @lunny
Add ActionRunStatus component (#23259)
f0b0f22 
Related to:
#23212 (comment)

Decrease duplication of SvgIcon when display a run status svg.

---------

Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot
Copy link
Contributor

GiteaBot commented Mar 9, 2023

I was unable to create a backport for 1.19, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 9, 2023
@yp05327 yp05327 deleted the add-run-status-in-action-viwe-page branch March 13, 2023 01:06
@yp05327 yp05327 restored the add-run-status-in-action-viwe-page branch April 20, 2023 05:39
@yp05327 yp05327 deleted the add-run-status-in-action-viwe-page branch April 20, 2023 05:57
@yp05327 yp05327 mentioned this pull request Apr 20, 2023
Merged
silverwind pushed a commit that referenced this pull request Apr 20, 2023
@yp05327
Add run status in action view page (#24223)
95c2cb4 
Backport #23212
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 26, 2023

Please remove backport/manual tag, as #24223 is merged.

@silverwind silverwind removed the backport/manual No power to the bots! Create your backport yourself! label Apr 26, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19. @yp05327, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 26, 2023
@silverwind silverwind removed outdated/backport/v1.19 This PR should be backported to Gitea 1.19 backport/manual No power to the bots! Create your backport yourself! labels Apr 26, 2023
@silverwind
Copy link
Member

@yardenshoham what is the correct method to prevent re-addition of backport/manual like above? Set to backport/done?

@silverwind silverwind added backport/done All backports for this PR have been created outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 26, 2023
@silverwind
Copy link
Member

Seems like adding backport/done works :)

@yardenshoham
Copy link
Member

Yes, if you manually create a backport you should add backport/done

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh left review comments

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/gitea-actions related to the actions of Gitea topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@yp05327 @lunny @GiteaBot @silverwind @yardenshoham @wolfogre @delvh @techknowlogick