Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel creating commit status bug with tests #21911

Merged
merged 13 commits into from
Nov 30, 2022
Merged

Fix parallel creating commit status bug with tests #21911

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
12519e8
Add test for parallel creating commit status tests
lunny Nov 23, 2022
d0408c4
ignore sqlite3
lunny Nov 24, 2022
e2b4c2a
Merge branch 'main' into lunny/commit_status
lunny Nov 24, 2022
fd79a0b
Merge branch 'main' into lunny/commit_status
lunny Nov 25, 2022
9df1f90
Merge branch 'main' into lunny/commit_status
lunny Nov 25, 2022
a1e3418
Fix test
lunny Nov 25, 2022
0fb5677
Fix test
lunny Nov 29, 2022
09cd8bb
Merge branch 'main' into lunny/commit_status
lunny Nov 29, 2022
0d4c6b3
Fix bug
lunny Nov 29, 2022
bf50a91
remove sqlite condition in test
lunny Nov 29, 2022
a46e7e2
Remove unused const variable
lunny Nov 29, 2022
63a51f0
Merge branch 'main' into lunny/commit_status
lunny Nov 30, 2022
a295bf9
Merge branch 'main' into lunny/commit_status
lafriks Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@lunny
lunny committed Nov 29, 2022
commit 0fb567718466c47f2946c144f42828a7949eab3b
10 changes: 5 additions & 5 deletions tests/integration/repo_commits_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@ func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) {
t.Run("CreateStatus", doAPICreateCommitStatus(NewAPITestContext(t, "user2", "repo1"), path.Base(commitURL), api.CommitStatusState(state)))

if !setting.Database.UseSQLite3 {
runBody := doAPICreateCommitStatus(NewAPITestContext(t, "user2", "repo1"), path.Base(commitURL), api.CommitStatusState(state))
var wg sync.WaitGroup
for i := 0; i < 10; i++ {
wg.Add(1)
t.Run(fmt.Sprintf("ParallelCreateStatus_%d", i), func(t *testing.T) {
go func(t *testing.T) {
go func(t *testing.T, i int) {
t.Run(fmt.Sprintf("ParallelCreateStatus_%d", i), func(t *testing.T) {
runBody := doAPICreateCommitStatus(NewAPITestContext(t, "user2", "repo1"), path.Base(commitURL), api.CommitStatusState(state))
runBody(t)
wg.Done()
}(t)
})
})
}(t, i)
}
wg.Wait()
}
Expand Down