Add missing path in the Docker app.ini template

[twang2218]

Some paths are missing in the Docker image's app.ini template, it will cause the gitea create files out of the /data directory. This PR added the missing paths.

Signed-off-by: Tao Wang [email protected]

[lafriks]

I don't think it is good default for LFS, I think better would be /data/git/lfs as repositories is stored in /data/git/repositories directory

[twang2218]

Yes, you are right. They are all git related stuff, so it's better they stay together. I'll change it to /data/git/lfs as you suggested.

[twang2218]

Updated with LFS_CONTENT_PATH = /data/git/lfs

[twang2218]

There is one more thing I want to mention, as all missing paths are added, the /app/gitea/indexers will not be created, and gitea binary is the only file in the /app/gitea/ directory. Should we move the gitea binary to more standard place, such as /usr/local/bin/?

One benefit would be that, when user enter the container via docker exec -it xxxx bash, they can directly call gitea command, without full path /app/gitea/gitea.

[twang2218]

Added another commit of moving gitea binary from /app/gitea/ to /usr/local/bin/

[silverwind]

moving gitea binary from /app/gitea/ to /usr/local/bin/

maybe it's better to just symlink it?

[lunny]

@twang2218 why move gitea binary from /app/gitea/ to /usr/local/bin/

[twang2218]

why move gitea binary from /app/gitea/ to /usr/local/bin/

@lunny because

1. gitea binary is the only file in the /app/gitea/ directory after this changes, there is not much reason to keep this directory anymore.
2. moving the gitea binary to more standard place, such as /usr/local/bin/, will make gitea command globally available, especially useful when docker exec -it gitea bash to enter the container and run gitea commands without using the full path, /app/gitea/gitea.

If there are any other parts using hardcoded /app/gitea/gitea path, I can make a symlink there to has better backward compatibility.

[twang2218]

Rebased to resolve the conflict, and add symlink to /app/gitea/gitea for compatibility.

# For backward compatibility
RUN mkdir -p /app/gitea/ && ln -s /usr/local/bin/gitea /app/gitea/gitea

Updated: removed unnecessary chmod.

[codecov-io]

Codecov Report

Merging #2181 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2181      +/-   ##
==========================================
- Coverage    20.1%   20.09%   -0.01%     
==========================================
  Files         153      153              
  Lines       30716    30716              
==========================================
- Hits         6174     6171       -3     
- Misses      23599    23601       +2     
- Partials      943      944       +1

Impacted Files	Coverage Δ
modules/process/manager.go	69.56% <0%> (-4.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5676f60...a146655. Read the comment docs.

[daviian]

@twang2218 PR needs rebase to resolve conflicts.

[twang2218]

Rebased now.

[sapk]

This will not break older version since the app.ini will not be regenerated.

[sapk]

Maybe we could add the config to activate related function (lfs, indexer) as env config. This could be done in an other PR.

[techknowlogick]

I've just restarted Drone CI so hopefully it passes.