Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip init after review #20814

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Fix tooltip init after review #20814

merged 2 commits into from
Aug 16, 2022

Conversation

silverwind
Copy link
Member

Previous code passed a jQuery collection which initTooltip couldn't handle. Instead, iterate the individial matched elements and add a dollar to the variable name to make it clear it's jQuery.

Fixes: #20809

@silverwind
Fix tooltip init after review
545f012 
Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: go-gitea#20809
@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 16, 2022
@silverwind silverwind added this to the 1.18.0 milestone Aug 16, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 16, 2022
@silverwind
Copy link
Member Author

I also renamed form to $form for clarity, which then made eslint hit on jquery/no-serialize, so I replaced $form.serialize with the modern vanilla js equivalent.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2022
@lafriks lafriks merged commit 1e0fcd1 into go-gitea:main Aug 16, 2022
@silverwind silverwind deleted the fix-tooltip-init branch August 16, 2022 22:18
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 17, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 17, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8870bf4 
* giteaofficial/main:
  Add proxy host into allow list (go-gitea#20798)
  Fix tooltip init after review (go-gitea#20814)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
@silverwind
Fix tooltip init after review (go-gitea#20814)
9f26437 
* Fix tooltip init after review

Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: go-gitea#20809
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Post a review comment on pull request files view frontend error.
5 participants
@silverwind @lafriks @Gusted @lunny @GiteaBot