Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move agit dependency #19998

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Move agit dependency #19998

merged 1 commit into from
Jun 17, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 17, 2022

The right dependency is router depends on services level but not opposite.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 17, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2022
@6543 6543 added this to the 1.17.0 milestone Jun 17, 2022
@6543 6543 merged commit 27ba86d into go-gitea:main Jun 17, 2022
@lunny lunny deleted the lunny/refactor_service branch June 18, 2022 02:31
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@lunny
move agit dependcy (go-gitea#19998)
be9bbf4
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
move agit dependcy (go-gitea#19998)
dee1a92
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @6543 @a1012112796 @GiteaBot