-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github style following followers #19482
Conversation
You're currently targeting the main branch(which is 1.17), could be just me, but the current layout doesn't seem to be correct. |
I would deploy 1.17 just in case if I can reproduce this. I will send css patch if I can with this same PR. |
templates/user/profile.tmpl
Outdated
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i> | ||
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> . | ||
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i> | |
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> . | |
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a> | |
<a class="muted" href="{{.Owner.HomeLink}}?tab=followers">{{svg "octicon-person" 18 "mr-2"}}{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> · <a class="muted" href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I really needed the "muted" class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything missing? The UI on try.gitea.io is not the same as the screenshot.
I built the main branch. The CSS is indeed incorrect on 1.17(ba7750d). 1.16 branch is fine. I will check the CSS diff on both on both branch. |
text-decoration: none; for follower, following links Co-authored-by: silverwind <[email protected]>
* giteaofficial/main: Github style following followers (go-gitea#19482) alpine 3.16 (go-gitea#19797)
Hmmm ....... it's broken ...... |
Ooops, I forgot to suggest the wrapper div, fix in #19805. |
Removed tabbed following and followers from user page and added Github style following followers.
Removed tabbed following and followers from user page and added Github style following followers.