Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage for original author conversion during migrations #18506

Merged
merged 8 commits into from
Feb 1, 2022
Merged

add test coverage for original author conversion during migrations #18506

merged 8 commits into from
Feb 1, 2022

Conversation

singuliere
Copy link
Contributor

@singuliere singuliere commented Jan 31, 2022 •
edited
Loading

And create a function to factorize a code snippet that is repeated
five times and would otherwise be more difficult to test and maintain
consistently.

Signed-off-by: Loïc Dachary [email protected]

forgefriends source

@singuliere
add test coverage for original author conversion during migrations
e54904d 
And create a function to factorize a code snippet that is repeated
five times and would otherwise be more difficult to test and maintain
consistently.

Signed-off-by: Loïc Dachary <[email protected]>
@singuliere singuliere added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Jan 31, 2022
@singuliere singuliere added this to the 1.17.0 milestone Jan 31, 2022
Gusted
Gusted reviewed Jan 31, 2022
View reviewed changes
services/migrations/gitea_uploader.go Outdated Show resolved Hide resolved
services/migrations/gitea_uploader_test.go Outdated Show resolved Hide resolved
services/migrations/gitea_uploader_test.go Outdated Show resolved Hide resolved
services/migrations/gitea_uploader.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2022
Gusted
Gusted approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good now.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@6f6b849). Click here to learn what that means.
The diff coverage is 39.32%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18506   +/-   ##
=======================================
  Coverage        ?   46.31%           
=======================================
  Files           ?      846           
  Lines           ?   121123           
  Branches        ?        0           
=======================================
  Hits            ?    56102           
  Misses          ?    58221           
  Partials        ?     6800
Impacted Files Coverage Δ
models/release.go 49.45% <0.00%> (ø)
models/review.go 50.29% <0.00%> (ø)
models/user/external_login_user.go 28.57% <ø> (ø)
modules/migration/pullrequest.go 0.00% <0.00%> (ø)
modules/migration/release.go 0.00% <0.00%> (ø)
modules/migration/review.go 0.00% <0.00%> (ø)
services/migrations/gitea_uploader.go 29.32% <37.83%> (ø)
models/issue.go 54.34% <62.50%> (ø)
models/issue_comment.go 52.09% <62.50%> (ø)
models/issue_reaction.go 81.93% <62.50%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6b849...204018c. Read the comment docs.

@techknowlogick techknowlogick merged commit 367894a into go-gitea:main Feb 1, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 2, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8503c0b 
* giteaofficial/main: (37 commits)
  Collaborator trust model should trust collaborators (go-gitea#18539)
  Detect conflicts with 3way merge (go-gitea#18536)
  [skip ci] Updated translations via Crowdin
  Update 1.16.0 changelog to set go-gitea#17846 as breaking (go-gitea#18533)
  In docker rootless use $GITEA_APP_INI if provided (go-gitea#18524)
  revert to node14 for snapcraft
  Add `GetUserTeams` (go-gitea#18499)
  Fix review excerpt (go-gitea#18502)
  Update JS dependencies, fix lint (go-gitea#18389)
  add test coverage for original author conversion during migrations (go-gitea#18506)
  add gitea-fmt back (go-gitea#18526)
  Fix non-ASCII search on database  (go-gitea#18437)
  Use "read" value for General Access (go-gitea#18496)
  Fix for AvatarURL database type (go-gitea#18487)
  Remove go 1.15 support (go-gitea#18511)
  [skip ci] Updated translations via Crowdin
  Use `ImagedProvider` for gplus oauth2 provider (go-gitea#18504)
  build with node16 in snap (go-gitea#18508)
  point to s3 endpoint directly (go-gitea#18497)
  Fix OAuth Source Edit Page (go-gitea#18495)
  ...
@singuliere singuliere added the topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them label Feb 4, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@singuliere @lunny
@wxiaoguang @techknowlogick
add test coverage for original author conversion during migrations (g…
e41950b 
…o-gitea#18506)

* add test coverage for original author conversion during migrations

And create a function to factorize a code snippet that is repeated
five times and would otherwise be more difficult to test and maintain
consistently.

Signed-off-by: Loïc Dachary <[email protected]>

* fix variable scope and int64 formatting

* add missing calls to remapExternalUser and fix misplaced %d

Co-authored-by: Loïc Dachary <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@singuliere @codecov-commenter @lunny @Gusted @techknowlogick @GiteaBot @wxiaoguang