Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid issues #18111

Merged
merged 8 commits into from
Dec 28, 2021
Merged

Handle invalid issues #18111

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
202c3aa
Handle invalid issues
Gusted Dec 26, 2021
3b87a0d
Add I18N
Gusted Dec 26, 2021
cc7658c
Merge branch 'main' into handle-invalid-issues
lunny Dec 27, 2021
01f2dfc
refactor
wxiaoguang Dec 28, 2021
b177198
fix comment for lint
wxiaoguang Dec 28, 2021
d95ccf1
fix unit test for i18n
wxiaoguang Dec 28, 2021
663b97b
fix unit test for i18n
wxiaoguang Dec 28, 2021
b14f115
add comments
wxiaoguang Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix unit test for i18n
  • Loading branch information
@wxiaoguang
wxiaoguang committed Dec 28, 2021
commit 663b97be4171ed15ef6b7a153a95f2baf2806479
2 changes: 1 addition & 1 deletion integrations/api_releases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func TestAPIGetReleaseByTag(t *testing.T) {

var err *api.APIError
DecodeJSON(t, resp, &err)
assert.EqualValues(t, "Not Found", err.Message)
assert.NotEmpty(t, err.Message)
}

func TestAPIDeleteReleaseByTagName(t *testing.T) {
Expand Down