Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when read mysql database max lifetime #17682

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fix bug when read mysql database max lifetime #17682

merged 2 commits into from
Nov 17, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 17, 2021

It's a typo

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #17682 (7f592e2) into main (95d3266) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17682   +/-   ##
=======================================
  Coverage   45.33%   45.34%           
=======================================
  Files         799      799           
  Lines       89062    89062           
=======================================
+ Hits        40377    40383    +6     
+ Misses      42190    42185    -5     
+ Partials     6495     6494    -1
Impacted Files Coverage Δ
modules/setting/database.go 61.22% <50.00%> (ø)
models/repo_list.go 78.43% <0.00%> (-0.79%) ⬇️
modules/queue/workerpool.go 50.00% <0.00%> (+1.14%) ⬆️
modules/convert/repository.go 98.21% <0.00%> (+1.78%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d3266...7f592e2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2021
@wxiaoguang wxiaoguang merged commit 29cc169 into go-gitea:main Nov 17, 2021
@lunny lunny deleted the lunny/fix_max_lifetime branch November 17, 2021 12:55
lunny added a commit to lunny/gitea that referenced this pull request Nov 17, 2021
@lunny
Fix bug when read mysql database max lifetime (go-gitea#17682)
a21c7c5
@lunny lunny mentioned this pull request Nov 17, 2021
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 17, 2021
lunny added a commit that referenced this pull request Nov 17, 2021
@lunny
Fix bug when read mysql database max lifetime (#17682) (#17690)
0305a73
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix bug when read mysql database max lifetime (go-gitea#17682)
afd005e
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-commenter @a1012112796 @delvh @wxiaoguang @GiteaBot