Allow updating draft releases while keeping them as draft #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
suggested changes
Nov 14, 2016
| @@ -247,6 +247,7 @@ func EditRelease(ctx *context.Context) { | |||
| ctx.Data["title"] = rel.Title | |||
| ctx.Data["content"] = rel.Note | |||
| ctx.Data["prerelease"] = rel.IsPrerelease | |||
| ctx.Data["draft"] = rel.IsDraft | |||
There was a problem hiding this comment.
Should be ctx.Data["IsDraft"]
If you feel like it, you might as well fix the above ones as well. Though not related to this issue 🙂
There was a problem hiding this comment.
I'd prefer keeping commits focused on what they address. There are also still ALL_UPPER_CASE constants in that file, but would rather not touch now. Can change the IsDraft though, being a new one.
bkcsoft
approved these changes
Nov 14, 2016
|
LGTM |
bkcsoft
added
type/bug
lgtm/done
strk
force-pushed
the
allow-update-draft-releases
branch
from
0feb003
to
cd33926
Compare
|
LGTM |
Current coverage is 3.03% (diff: 100%)@@ master #169 diff @@
========================================
Files 33 33
Lines 8096 8096
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
Misses 7830 7830
Partials 20 20
|
tboerger
removed
the
lgtm/done
tboerger
added
the
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162