Support system proxy #15234
Closed
Support system proxy #15234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
silverwind
reviewed
Apr 1, 2021
| [proxy] | ||
| ; Enable the proxy, all requests to external via HTTP will be affected | ||
| PROXY_ENABLED = false | ||
| ; Proxy server URL, support http:https://, https//, socks:https://, blank will follow environment http_proxy/https_proxy |
There was a problem hiding this comment.
Suggested change
| ; Proxy server URL, support http:https://, https//, socks:https://, blank will follow environment http_proxy/https_proxy | |
| ; Proxy server URL, support http:https://, https//, socks:https://, blank will follow environment http_proxy/https_proxy/no_proxy |
GiteaBot
added
the
lgtm/need 2
|
I think "system proxy" is a misleading term because at least on Linux, the OS does not have such a facility, it's all in environment variables. |
|
The name For git, it also has |
lunny
force-pushed
the
lunny/system_proxy
branch
from
051cbf1
to
85906b8
Compare
lunny
force-pushed
the
lunny/system_proxy
branch
from
85906b8
to
1679c76
Compare
This was referenced Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a system proxy supports which should be applied to every request to external http/https URL.
Follow requests will follow the proxy setting if no standalone setting.
depend on #15241
And since webhook has supported standalone proxy, webhook's proxy settings will override the system proxy settings.
This PR also added an option to ignore tls verify on migrations.