-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect on bad CSRF instead of presenting bad page #14937
Conversation
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Hmm, this certainly improves UE greatly, but I don't think merging this should close that issue entirely (although that issue lacks details for further investigation to take place). |
But the submitted form information will be lost. Before we can click |
The back button still works for me. |
Codecov Report
@@ Coverage Diff @@
## main #14937 +/- ##
==========================================
- Coverage 45.51% 45.51% -0.01%
==========================================
Files 709 709
Lines 83755 83767 +12
==========================================
+ Hits 38120 38124 +4
- Misses 39500 39508 +8
Partials 6135 6135
Continue to review full report at Codecov.
|
I think it's better to back port to v1.14 |
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <[email protected]>
-> #16378 |
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <[email protected]>
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages
I think we can be a little kinder and redirect to base page with a flash error
Fix #14167
Signed-off-by: Andrew Thornton [email protected]