Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when adding long comment #12892

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

mrsdizzie
Copy link
Member

Previous PR #12881 causes out of bounds panic by working on wrong string.

Previous PR go-gitea#12881 causes out of bounds panic by working on wrong string.
@mrsdizzie mrsdizzie added backport/v1.12 type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 18, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12892 into master will decrease coverage by 0.00%.
The diff coverage is 87.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12892      +/-   ##
==========================================
- Coverage   43.11%   43.11%   -0.01%     
==========================================
  Files         656      657       +1     
  Lines       72353    72340      -13     
==========================================
- Hits        31194    31186       -8     
+ Misses      36107    36104       -3     
+ Partials     5052     5050       -2     
Impacted Files Coverage Δ
modules/notification/action/action.go 58.26% <0.00%> (ø)
modules/convert/convert.go 73.00% <50.00%> (-2.37%) ⬇️
modules/convert/issue.go 87.30% <86.20%> (-0.33%) ⬇️
modules/convert/git_commit.go 88.28% <88.28%> (ø)
models/issue_stopwatch.go 70.37% <100.00%> (-2.97%) ⬇️
routers/api/v1/repo/commits.go 57.31% <100.00%> (-14.30%) ⬇️
routers/api/v1/repo/hook.go 26.41% <100.00%> (ø)
routers/api/v1/repo/issue_stopwatch.go 52.63% <100.00%> (ø)
modules/indexer/stats/db.go 60.86% <0.00%> (-8.70%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7250f53...52623b6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2020
@mrsdizzie mrsdizzie added this to the 1.13.0 milestone Sep 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2020
@techknowlogick techknowlogick merged commit 25ddf77 into go-gitea:master Sep 18, 2020
mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Sep 18, 2020
Previous PR go-gitea#12881 causes out of bounds panic by working on wrong string.
techknowlogick pushed a commit that referenced this pull request Sep 18, 2020
Previous PR #12881 causes out of bounds panic by working on wrong string.
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 12, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants