Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for push options #12169

Merged
merged 11 commits into from
Aug 23, 2020
Merged

Conversation

jolheiser
Copy link
Member

Will resolve #12160

This PR will add some support for push options.

Currently it is limited to changing repo visibility and whether it is a template or not, however more could be added in the future.

@jolheiser jolheiser added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 6, 2020
@jolheiser jolheiser added this to the 1.13.0 milestone Jul 6, 2020
Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser marked this pull request as ready for review July 7, 2020 21:07
cmd/doctor.go Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2020
modules/git/git.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 18, 2020
lunny
lunny previously requested changes Aug 18, 2020
routers/private/hook.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #12169 into master will decrease coverage by 0.00%.
The diff coverage is 2.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12169      +/-   ##
==========================================
- Coverage   43.43%   43.43%   -0.01%     
==========================================
  Files         644      644              
  Lines       71203    71246      +43     
==========================================
+ Hits        30925    30943      +18     
- Misses      35263    35287      +24     
- Partials     5015     5016       +1     
Impacted Files Coverage Δ
cmd/doctor.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
modules/private/hook.go 0.00% <0.00%> (ø)
routers/private/hook.go 29.52% <0.00%> (-0.60%) ⬇️
modules/git/git.go 37.66% <33.33%> (-0.18%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/queue/workerpool.go 62.04% <0.00%> (+3.26%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (+11.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d65cb...cdf0926. Read the comment docs.

@zeripath zeripath merged commit 43a397c into go-gitea:master Aug 23, 2020
@jolheiser jolheiser deleted the push_option branch August 25, 2020 21:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we create publicly access repos while creating repos using git push from command line
7 participants