Last Login for admin manage your users #121

joubertredrat · 2016-11-08T13:57:00Z

This PR fixes #57

PS: Thanks @lunny for help on final with i18n.

thibaultmeyer · 2016-11-08T13:57:52Z

Good job, maybe you could try to rebase your commits into one commit ?

thibaultmeyer · 2016-11-08T13:58:41Z

models/user.go

@@ -119,6 +121,10 @@ func (u *User) BeforeUpdate() {
 u.UpdatedUnix = time.Now().Unix()
 }

+func (u *User) AfterLogin() {


Maybe UpdateLastLogin will be a more appropriate name for this function

@0xBAADF00D I chose this name because it is generic, it may be that in the future another implementation can be done in this same method. But I can change if is necessary.

joubertredrat · 2016-11-08T14:00:39Z

@0xBAADF00D I can provide this, but Isn't it better to keep? Because first commit references the implementation on the route, while the last commit describes changes in the admin panel.

codecov-io · 2016-11-08T14:10:13Z

Current coverage is 3.14% (diff: 0.00%)

Merging #121 into master will decrease coverage by <.01%

@@            master      #121   diff @@
========================================
  Files           33        33          
  Lines         7823      7827     +4   
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
- Misses        7557      7561     +4   
  Partials        20        20

Powered by Codecov. Last update 475ddd8...f91cbf0

DblK

Add missing comments for linting

DblK · 2016-11-08T15:32:41Z

models/user.go

@@ -119,6 +121,10 @@ func (u *User) BeforeUpdate() {
 u.UpdatedUnix = time.Now().Unix()
 }

+func (u *User) AfterLogin() {


Could you provide some comments for the linting of your function?

DblK · 2016-11-08T15:33:09Z

models/user.go

+func (u *User) AfterLogin() {
+ u.LastLoginUnix = time.Now().Unix()
+}
+
 func (u *User) AfterSet(colName string, _ xorm.Cell) {


Could you add a comment for the function for the linting?

metalmatze · 2016-11-08T17:24:42Z

I think you can keep your commits. Please make sure that your PRs are rebased once they're going to be merged, but that's it. You just need to squash if you feel like it's a good idea, but we don't force you to.

joubertredrat · 2016-11-08T17:47:45Z

@metalmatze redone all as one commit by reset

andreynering · 2016-11-08T22:09:40Z

models/user.go

@@ -119,6 +121,11 @@ func (u *User) BeforeUpdate() {
 u.UpdatedUnix = time.Now().Unix()
 }

+// Set time to last login
+func (u *User) UpdateLastLogin() {


Maybe name this SetLastLogin()? Update is a bit misleading, it would be apropriate if this actually saved the change to the database.

@andreynering, @0xBAADF00D asked to pu this name, originally was setAfterLogin()

Maybe UpdateLastLogin will be a more appropriate name for this function

I will provide fix for this tomorrow.

I like SetLastLogin()

andreynering · 2016-11-08T22:37:08Z

It's working fine. Can be merged after update.

lunny · 2016-11-09T07:43:33Z

Yes. It's ready for merge. @0xBAADF00D @DblK Please check and Dismiss review.

joubertredrat · 2016-11-09T10:58:17Z

Recommit with last changes

andreynering · 2016-11-09T11:02:33Z

LGTM

bkcsoft · 2016-11-09T12:49:59Z

LGTM

lunny · 2016-11-09T13:27:14Z

Could we dismiss or wait for @0xBAADF00D @DblK ?

bkcsoft

fix gofmt lint-errors

bkcsoft · 2016-11-09T14:04:04Z

models/user.go

@@ -119,6 +121,11 @@ func (u *User) BeforeUpdate() {
 u.UpdatedUnix = time.Now().Unix()
 }

+// Set time to last login


This comment has to start with the function-name, e.g // SetLastLogin sets the time of last login. May sound stupid, but go fmt requires it 😒

@bkcsoft Okay, I will provide this

bkcsoft · 2016-11-09T14:04:31Z

models/user.go

+func (u *User) SetLastLogin() {
+ u.LastLoginUnix = time.Now().Unix()
+}
+
 func (u *User) AfterSet(colName string, _ xorm.Cell) {


Same here, it requires a comment that starts with // AfterSet

@bkcsoft AfterSet wasn't written by me, then I think that I don't know that this function make. I can take advantage of my commit and put it, but I'll need help to understand this function. Or I can put only // AfterSet

@bkcsoft can be // AfterSet format data from database for display?

// AfterSet does magic (ask @lunny since he knows XORM 🙂 )

@lunny now the ball is with you

I agree with @andreynering, comment these should be another PR.

joubertredrat · 2016-11-09T15:52:01Z

@bkcsoft add comments on BeforeInsert, BeforeUpdate, APIFormat, RepoCreationNum, CanCreateRepo, IsFollowing, ShortName, IsUsableUsername, countUsers, updateUser, GetUserByKeyID, getUserByID, IsFollowing too?

andreynering · 2016-11-09T17:20:58Z

If that function doesn't change in this PR, you don't need to change that.

Someone can send another PR for that.

Em qua, 9 de nov de 2016 às 14:36, Joubert RedRat [email protected]
escreveu:

@bkcsoft https://github.com/bkcsoft add comments on BeforeInsert,
BeforeUpdate, APIFormat, RepoCreationNum, CanCreateRepo, IsFollowing,
ShortName, IsUsableUsername, countUsers, updateUser, GetUserByKeyID,
getUserByID, IsFollowing too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#121 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGr962U05vISAsWD1F0xYl-7137tn5PQks5q8ewigaJpZM4Ksc3s
.

lunny · 2016-11-10T05:19:05Z

@DblK, hi, please review and it's ready for merge.

joubertredrat · 2016-11-10T10:45:51Z

@bkcsoft, @lunny merged before my changes on comments as you requested, don't have problem on this?

This comment has to start with the function-name, e.g // SetLastLogin sets the time of last login. May sound stupid, but go fmt requires it 😒

strk · 2016-11-10T11:16:24Z

On Thu, Nov 10, 2016 at 02:45:52AM -0800, Joubert RedRat wrote:

@bkcsoft, @lunny merged before my changes on comments as you requested, don't have problem on this?

Please file another PR with further changes (merge rate is still wild :)

lunny · 2016-11-10T11:28:08Z

^

* Add repo_blob This adds a new Repository.GetBlob(id) method for use by gitea. * This is a follow-up for PR go-gitea#121 to implement blob_api including full test coverage Signed-off-by: Berengar W. Lehr <[email protected]>

thibaultmeyer suggested changes Nov 8, 2016

View reviewed changes

DblK suggested changes Nov 8, 2016

View reviewed changes

andreynering reviewed Nov 8, 2016

View reviewed changes

lunny added this to the 1.0.0 milestone Nov 9, 2016

lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Nov 9, 2016

Support to last login feature

f91cbf0

thibaultmeyer approved these changes Nov 9, 2016

View reviewed changes

bkcsoft suggested changes Nov 9, 2016

View reviewed changes

bkcsoft approved these changes Nov 9, 2016

View reviewed changes

DblK approved these changes Nov 10, 2016

View reviewed changes

DblK added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 10, 2016

lunny merged commit 1b238fe into go-gitea:master Nov 10, 2016

tboerger removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality labels Nov 12, 2016

tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016

HoffmannP mentioned this pull request Nov 14, 2018

Add raw blob endpoint to get objects by SHA ID #5334

Merged

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Last Login for admin manage your users #121

Last Login for admin manage your users #121

Conversation

joubertredrat commented Nov 8, 2016 • edited Loading

thibaultmeyer commented Nov 8, 2016

thibaultmeyer Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joubertredrat commented Nov 8, 2016

codecov-io commented Nov 8, 2016 • edited Loading

Current coverage is 3.14% (diff: 0.00%)

DblK left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metalmatze commented Nov 8, 2016

joubertredrat commented Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

joubertredrat Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreynering commented Nov 8, 2016

lunny commented Nov 9, 2016

joubertredrat commented Nov 9, 2016

andreynering commented Nov 9, 2016 • edited Loading

bkcsoft commented Nov 9, 2016

lunny commented Nov 9, 2016

bkcsoft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joubertredrat Nov 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joubertredrat commented Nov 9, 2016

andreynering commented Nov 9, 2016

lunny commented Nov 10, 2016

joubertredrat commented Nov 10, 2016 • edited Loading

strk commented Nov 10, 2016

lunny commented Nov 10, 2016

joubertredrat commented Nov 8, 2016 •

edited

Loading

thibaultmeyer Nov 8, 2016 •

edited

Loading

codecov-io commented Nov 8, 2016 •

edited

Loading

joubertredrat commented Nov 8, 2016 •

edited

Loading

joubertredrat Nov 8, 2016 •

edited

Loading

andreynering commented Nov 9, 2016 •

edited

Loading

joubertredrat Nov 9, 2016 •

edited

Loading

joubertredrat commented Nov 10, 2016 •

edited

Loading