[Backport] Fix commenting on non-utf8 encoded files (#11916) #11950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add comment on non-unicode line to force fail Signed-off-by: Andrew Thornton <[email protected]> * Just quote/unquote patch Signed-off-by: Andrew Thornton <[email protected]>
6543
changed the title
adelowo
approved these changes
Jun 18, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Jun 18, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11916
Add comment on non-unicode line to force fail
Just quote/unquote patch
Signed-off-by: Andrew Thornton [email protected]