Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework api/user/repos for pagination (#11827) #11877

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Rework api/user/repos for pagination (#11827) #11877

merged 1 commit into from
Jun 13, 2020

Commits on Jun 13, 2020

  1. Rework api/user/repos for pagination (go-gitea#11827) 

    * Add count to `GetUserRepositories` so that pagination can be supported for `/user/{username}/repos`
* Rework ListMyRepos to use models.SearchRepository

ListMyRepos was an odd one. It first fetched all user repositories and then tried to supplement them with accessible map. The end result was that:

* Limit for pagination did not work because accessible repos would always be appended
* The amount of pages was incorrect if one were to calculate it
* When paginating, all accessible repos would be shown on every page

Hopefully it should now work properly. Fixes go-gitea#11800 and does not require any change on Drone-side as it can properly interpret and act on Link header which we now set.

Co-authored-by: Lauris BH <[email protected]>
(cherry picked from commit 0159851)
    @CirnoT
    CirnoT committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    19a27db View commit details
    Browse the repository at this point in the history